[webcrypto] Add deriveBits key_op to JWK import/export.

[webcrypto] Add deriveBits key_op to JWK import/export.

BUG=245025
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272291

[Ryan Sleevi, 2014-05-09 00:06:03]

https://codereview.chromium.org/267323009/diff/1/content/child/webcrypto/shar...
File content/child/webcrypto/shared_crypto_unittest.cc (right):

https://codereview.chromium.org/267323009/diff/1/content/child/webcrypto/shar...
content/child/webcrypto/shared_crypto_unittest.cc:1201:
blink::WebCryptoKeyUsageDeriveBits}};
Hrm. Not sure if a spec bug or not that you can import HMAC keys that support
operations that the underlying algorithm does not...

[eroman, 2014-05-09 00:36:49]

https://codereview.chromium.org/267323009/diff/1/content/child/webcrypto/shar...
File content/child/webcrypto/shared_crypto_unittest.cc (right):

https://codereview.chromium.org/267323009/diff/1/content/child/webcrypto/shar...
content/child/webcrypto/shared_crypto_unittest.cc:1201:
blink::WebCryptoKeyUsageDeriveBits}};
On 2014/05/09 00:06:03, Ryan Sleevi wrote:
> Hrm. Not sure if a spec bug or not that you can import HMAC keys that support
> operations that the underlying algorithm does not...

It is not a spec bug, it is an implementation bug.

The spec says to fail such operations. Something I am going to work on next.

I will remove this then, since this isn't a valid long-term test

[Ryan Sleevi, 2014-05-13 05:52:25]

https://codereview.chromium.org/267323009/diff/20001/content/child/webcrypto/...
File content/child/webcrypto/shared_crypto_unittest.cc (left):

https://codereview.chromium.org/267323009/diff/20001/content/child/webcrypto/...
content/child/webcrypto/shared_crypto_unittest.cc:1188: // TODO(padolph): Add
'deriveBits' key_ops value once it is supported.
Seems like there's still a need for a test

[eroman, 2014-05-13 20:05:13]

https://codereview.chromium.org/267323009/diff/20001/content/child/webcrypto/...
File content/child/webcrypto/shared_crypto_unittest.cc (left):

https://codereview.chromium.org/267323009/diff/20001/content/child/webcrypto/...
content/child/webcrypto/shared_crypto_unittest.cc:1188: // TODO(padolph): Add
'deriveBits' key_ops value once it is supported.
On 2014/05/13 05:52:25, Ryan Sleevi wrote:
> Seems like there's still a need for a test

I will leave the TODO. It is not currently testable though through key import,
since no key type supporting deriveBits is implemented. When DH/ECDH are added I
can address this.

[eroman, 2014-05-21 03:21:17]

ping

[Ryan Sleevi, 2014-05-21 19:26:52]

lgtm

[eroman, 2014-05-22 14:01:35]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-05-22 14:02:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/267323009/60001

[commit-bot: I haz the power, 2014-05-22 20:05:09]

Change committed as 272291