Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2673183002: [Mac] Test for avatar bubble alignment logic (Closed)

Created:
3 years, 10 months ago by spqchan
Modified:
3 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Test for avatar bubble alignment logic BUG=670811 Review-Url: https://codereview.chromium.org/2673183002 Cr-Commit-Position: refs/heads/master@{#448283} Committed: https://chromium.googlesource.com/chromium/src/+/bf922e2200bef7f7bbb93c59299c292347db1d2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
spqchan
PTAL
3 years, 10 months ago (2017-02-04 01:38:39 UTC) #6
Avi (use Gerrit)
lgtm
3 years, 10 months ago (2017-02-04 02:42:25 UTC) #7
spqchan
On 2017/02/04 02:42:25, Avi wrote: > lgtm thanks!
3 years, 10 months ago (2017-02-04 03:29:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673183002/1
3 years, 10 months ago (2017-02-04 03:29:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-04 05:30:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673183002/1
3 years, 10 months ago (2017-02-06 17:18:36 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 17:31:31 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bf922e2200bef7f7bbb93c59299c...

Powered by Google App Engine
This is Rietveld 408576698