Turn on allocator shim on macOS.

mac: Turn on allocator shim.

Prior to this CL, all Malloc Zone functions were rerouted through a light-weight
shim that kills the process [in oom_killer_malloc] on failure. This CL instead
reroutes the functions to the allocator shim, which is cross-platform, and has
the same effect on failure. The allocator shim also provides the ability to
track all allocations.

BUG=677302
Review-Url: https://codereview.chromium.org/2673173002
Cr-Commit-Position: refs/heads/master@{#450302}
Committed: https://chromium.googlesource.com/chromium/src/+/ab510e5f21028950cec63965e024a40bd1ccba66

[erikchen, 2017-02-04 01:49:11]

erikchen@chromium.org changed reviewers:
+ primiano@chromium.org

[erikchen, 2017-02-04 01:49:11]

primiano: Please review.

[Primiano Tucci (use gerrit), 2017-02-06 10:43:59]

non-owner LGTM. please expand the commit message and add a BUG=. I guess not
everybody knows what "allocator shim" is, so this commit message would be quite
cryptic for most people.
Can you also check that the OutOfMemoryDeathTests actually work before turning
this on?

Also, once you get all lg's, would be great to get the trybots ready via a
dry-run and tick commit when there is less CL traffic, in order to get some
isolation in the chromeperf dashboard.
The best time in that regard seems to be 9-12 UTC [1], so I can tick it for you
once this is ready.

$ TZ=UTC git log --date=format:%H --format='%cd' --since=180days | sort | uniq
-c | sort -n
 752 12
 770 11
 816 07
 856 10
 858 09
 885 13
 895 08
 909 06
1018 05
1172 14
1261 04
1358 15
1454 03
1742 02
1782 16
2035 17
2099 01
2179 00
2225 20
2240 19
2286 18
2291 23
2318 22
2444 21

[erikchen, 2017-02-06 21:30:39]

Description was changed from

==========
Turn on allocator shim on macOS.

BUG=
==========

to

==========
mac: Turn on allocator shim.

Prior to this CL, all Malloc Zone functions were rerouted through a light-weight
shim that kills the process [in oom_killer_malloc] on failure. This CL instead
reroutes the functions to the allocator shim, which is cross-platform, and has
the same effect on failure. The allocator shim also provides the ability to
track all allocations.

BUG=677302
==========

[erikchen, 2017-02-11 01:28:55]

erikchen@chromium.org changed reviewers:
+ brettw@chromium.org

[erikchen, 2017-02-11 01:28:56]

brettw: Please review.

[brettw, 2017-02-11 05:04:35]

lgtm

[erikchen, 2017-02-13 18:31:04]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 18:31:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 19:43:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 19:43:53]

Dry run: This issue passed the CQ dry run.

[Primiano Tucci (use gerrit), 2017-02-14 09:18:56]

The CQ bit was checked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2017-02-14 09:18:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/2673173002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-02-14 09:19:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 09:24:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487063936200650,
"parent_rev": "d4541ca729baa0628bef1304616e3a3721f614bb", "commit_rev":
"ab510e5f21028950cec63965e024a40bd1ccba66"}

[commit-bot: I haz the power, 2017-02-14 09:24:48]

Description was changed from

==========
mac: Turn on allocator shim.

Prior to this CL, all Malloc Zone functions were rerouted through a light-weight
shim that kills the process [in oom_killer_malloc] on failure. This CL instead
reroutes the functions to the allocator shim, which is cross-platform, and has
the same effect on failure. The allocator shim also provides the ability to
track all allocations.

BUG=677302
==========

to

==========
mac: Turn on allocator shim.

Prior to this CL, all Malloc Zone functions were rerouted through a light-weight
shim that kills the process [in oom_killer_malloc] on failure. This CL instead
reroutes the functions to the allocator shim, which is cross-platform, and has
the same effect on failure. The allocator shim also provides the ability to
track all allocations.

BUG=677302

Review-Url: https://codereview.chromium.org/2673173002
Cr-Commit-Position: refs/heads/master@{#450302}
Committed:
https://chromium.googlesource.com/chromium/src/+/ab510e5f21028950cec63965e024...
==========

[commit-bot: I haz the power, 2017-02-14 09:24:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ab510e5f21028950cec63965e024...