Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2673113002: Remove implementation map from ChromeApplication (Closed)

Created:
3 years, 10 months ago by cco3
Modified:
3 years, 10 months ago
Reviewers:
aberent, Maria
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove implementation map from ChromeApplication Some exploration of this approach to generating upstream/downstream objects has revealed that it doesn't properly handle some use cases. BUG=685383, 687142 Review-Url: https://codereview.chromium.org/2673113002 Cr-Commit-Position: refs/heads/master@{#448084} Committed: https://chromium.googlesource.com/chromium/src/+/f5b9f2202525189a68dae03f3fc9adf1f299b8fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -45 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 4 chunks +0 lines, -45 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
cco3
3 years, 10 months ago (2017-02-03 19:07:49 UTC) #2
Maria
On 2017/02/03 19:07:49, cco3 wrote: Doesn't this also need to reinstate removed methods?
3 years, 10 months ago (2017-02-03 21:24:49 UTC) #3
cco3
On 2017/02/03 21:24:49, Maria wrote: > On 2017/02/03 19:07:49, cco3 wrote: > > Doesn't this ...
3 years, 10 months ago (2017-02-03 21:27:44 UTC) #4
Maria
lgtm
3 years, 10 months ago (2017-02-03 21:30:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673113002/1
3 years, 10 months ago (2017-02-03 21:31:14 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 22:08:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f5b9f2202525189a68dae03f3fc9...

Powered by Google App Engine
This is Rietveld 408576698