Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: Source/core/dom/Document.h

Issue 267303004: Oilpan: cleanup based on review comments after removal of TreeShared. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.h
diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h
index 7647cd84aa85dc877b922bf900340095b6a43cde..aa59e527f3a7cfd5bd453d7e0a5a340514a05c62 100644
--- a/Source/core/dom/Document.h
+++ b/Source/core/dom/Document.h
@@ -1321,6 +1321,7 @@ private:
RenderView* m_renderView;
+ // FIXME: Oilpan: We should use a real weak pointer here.
WeakPtrFactory<Document> m_weakFactory;
WeakPtr<Document> m_contextDocument;
@@ -1373,7 +1374,10 @@ private:
CompositorPendingAnimations m_compositorPendingAnimations;
RefPtrWillBeMember<Document> m_templateDocument;
- RawPtrWillBeMember<Document> m_templateDocumentHost; // Manually managed weakref (backpointer from m_templateDocument).
+ // With Oilpan the templateDocument and the templateDocumentHost
+ // live and die together. Without Oilpan, the templateDocumentHost
+ // is a manually managed backpointer from m_templateDocument.
+ RawPtrWillBeMember<Document> m_templateDocumentHost;
Timer<Document> m_didAssociateFormControlsTimer;
WillBeHeapHashSet<RefPtrWillBeMember<Element> > m_associatedFormControls;

Powered by Google App Engine
This is Rietveld 408576698