Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: Source/core/dom/Document.cpp

Issue 267303004: Oilpan: cleanup based on review comments after removal of TreeShared. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index f05dbc32bdab02d2bc001f22e16170b7ab3472c8..b73f49d50e9a6f2f8678936f7290d4b094bd2d78 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -2248,6 +2248,12 @@ void Document::detach(const AttachContext& context)
lifecycleNotifier().notifyDocumentWasDetached();
m_lifecycle.advanceTo(DocumentLifecycle::Stopped);
#if ENABLE(OILPAN)
+ // FIXME: Oilpan: With Oilpan dispose should not be needed. At
+ // this point we still have dispose in order to clear out some
+ // RefPtrs that would otherwise cause leaks. However, when the
+ // Document is detached the document can still be alive, so we
+ // really shouldn't clear anything at this point. It should just
+ // die with the document when the document is no longer reachable.
dispose();
#endif
}

Powered by Google App Engine
This is Rietveld 408576698