Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2673023002: Revert of Check HRESULT using macros in DXVAVideoDecodeAccelerator (Closed)

Created:
3 years, 10 months ago by Moe
Modified:
3 years, 10 months ago
Reviewers:
jrummell, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Check HRESULT using macros in DXVAVideoDecodeAccelerator (patchset #1 id:1 of https://codereview.chromium.org/2669083002/ ) Reason for revert: Causing failures in http/tests/media/media-source/mediasource-duration.html https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/8902 22:44:47.228 2772 worker/0 http/tests/media/media-source/mediasource-duration.html output stderr lines: 22:44:47.228 2772 [4800:5628:0202/224446.112:3700733:ERROR:audio_manager_win.cc(414)] GetPreferredAudioParameters failed: 88890004 22:44:47.228 2772 [5600:2452:0202/224446.116:3700749:INFO:gpu_video_decode_accelerator_factory.cc(181)] Initializing DXVA HW decoder for windows. 22:44:47.228 2772 [5600:2452:0202/224446.116:3700749:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 593 22:44:47.228 2772 [5600:2452:0202/224446.117:3700749:ERROR:gpu_video_decode_accelerator.cc(375)] HW video decode not available for profile vp8 22:44:47.228 2772 [4800:5628:0202/224446.123:3700749:ERROR:audio_manager_win.cc(414)] GetPreferredAudioParameters failed: 88890004 22:44:47.228 2772 [4800:5628:0202/224446.123:3700749:ERROR:audio_manager_base.cc(257)] Invalid audio output parameters received; using fake audio path. Channels: 0, Sample Rate: 0, Bits Per Sample: 0, Frames Per Buffer: 0 22:44:47.228 2772 [2916:5884:0202/224446.171:3700796:ERROR:gpu_video_decode_accelerator_host.cc(99)] Send(GpuCommandBufferMsg_CreateVideoDecoder()) failed 22:44:47.228 2772 [5600:4620:0202/224446.172:3700796:ERROR:gpu_channel.cc(564)] Could not find message queue 22:44:47.228 2772 [4800:5628:0202/224446.207:3700827:WARNING:audio_sync_reader.cc(188)] AudioSyncReader::Read timed out, audio glitch count=1 22:44:47.228 2772 [5600:2452:0202/224446.222:3700842:INFO:gpu_video_decode_accelerator_factory.cc(181)] Initializing DXVA HW decoder for windows. 22:44:47.228 2772 [5600:2452:0202/224446.223:3700842:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 593 22:44:47.228 2772 [5600:2452:0202/224446.223:3700842:ERROR:gpu_video_decode_accelerator.cc(375)] HW video decode not available for profile vp8 22:44:47.228 2772 [2916:5884:0202/224446.224:3700842:ERROR:gpu_video_decode_accelerator_host.cc(99)] Send(GpuCommandBufferMsg_CreateVideoDecoder()) failed 22:44:47.228 2772 [5600:4620:0202/224446.225:3700842:ERROR:gpu_channel.cc(564)] Could not find message queue 22:44:47.228 2772 [4800:5628:0202/224446.263:3700889:WARNING:audio_sync_reader.cc(188)] AudioSyncReader::Read timed out, audio glitch count=2 22:44:47.228 2772 [2916:5884:0202/224446.383:3701014:ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"Failed to reconcile encoded audio times with decoded output."} 22:44:47.228 2772 [5600:2452:0202/224446.405:3701030:INFO:gpu_video_decode_accelerator_factory.cc(181)] Initializing DXVA HW decoder for windows. 22:44:47.228 2772 [5600:2452:0202/224446.406:3701030:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 593 22:44:47.228 2772 [5600:2452:0202/224446.407:3701030:ERROR:gpu_video_decode_accelerator.cc(375)] HW video decode not available for profile vp8 22:44:47.228 2772 [2916:5884:0202/224446.410:3701030:ERROR:gpu_video_decode_accelerator_host.cc(99)] Send(GpuCommandBufferMsg_CreateVideoDecoder()) failed 22:44:47.228 2772 [5600:4620:0202/224446.411:3701030:ERROR:gpu_channel.cc(564)] Could not find message queue 22:44:47.229 2772 [5600:2452:0202/224446.412:3701030:INFO:gpu_video_decode_accelerator_factory.cc(181)] Initializing DXVA HW decoder for windows. 22:44:47.229 2772 [5600:2452:0202/224446.412:3701030:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 593 22:44:47.229 2772 [5600:2452:0202/224446.413:3701045:ERROR:gpu_video_decode_accelerator.cc(375)] HW video decode not available for profile vp8 22:44:47.229 2772 [2916:5884:0202/224446.414:3701045:ERROR:gpu_video_decode_accelerator_host.cc(99)] Send(GpuCommandBufferMsg_CreateVideoDecoder()) failed 22:44:47.229 2772 [5600:4620:0202/224446.415:3701045:ERROR:gpu_channel.cc(564)] Could not find message queue 22:44:47.229 2772 [5600:2452:0202/224446.416:3701045:INFO:gpu_video_decode_accelerator_factory.cc(181)] Initializing DXVA HW decoder for windows. 22:44:47.229 2772 [5600:2452:0202/224446.417:3701045:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 593 22:44:47.229 2772 [5600:2452:0202/224446.417:3701045:ERROR:gpu_video_decode_accelerator.cc(375)] HW video decode not available for profile vp8 22:44:47.229 2772 [2916:5884:0202/224446.419:3701045:ERROR:gpu_video_decode_accelerator_host.cc(99)] Send(GpuCommandBufferMsg_CreateVideoDecoder()) failed 22:44:47.229 2772 [5600:4620:0202/224446.419:3701045:ERROR:gpu_channel.cc(564)] Could not find message queue 22:44:47.229 2772 [2916:5884:0202/224446.431:3701061:ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"Failed to reconcile encoded audio times with decoded output."} 22:44:47.229 2772 [2916:5884:0202/224446.574:3701201:ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"Failed to reconcile encoded audio times with decoded output."} 22:44:47.229 2772 [2916:5884:0202/224446.575:3701201:ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"Failed to reconcile encoded audio times with decoded output."} 22:44:47.229 2772 [2916:5884:0202/224446.598:3701217:ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"Failed to reconcile encoded audio times with decoded output."} Original issue's description: > Check HRESULT using macros in DXVAVideoDecodeAccelerator > > /analyze on Windows complains about using HRESULT in a Boolean context, > so check returned values using the appropriate macro. > > BUG=687394 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2669083002 > Cr-Commit-Position: refs/heads/master@{#447925} > Committed: https://chromium.googlesource.com/chromium/src/+/5429b39dda87c47ace86635ab4cf998255ced5fb TBR=dalecurtis@chromium.org,jrummell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=687394 Review-Url: https://codereview.chromium.org/2673023002 Cr-Commit-Position: refs/heads/master@{#447989} Committed: https://chromium.googlesource.com/chromium/src/+/f0e9b0e1c113c2df05b2c6c71c6f4507d95a9415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M media/gpu/dxva_video_decode_accelerator_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Moe
Created Revert of Check HRESULT using macros in DXVAVideoDecodeAccelerator
3 years, 10 months ago (2017-02-03 14:28:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673023002/1
3 years, 10 months ago (2017-02-03 14:28:54 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 14:33:39 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f0e9b0e1c113c2df05b2c6c71c6f...

Powered by Google App Engine
This is Rietveld 408576698