Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions. The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
Review-Url: https://codereview.chromium.org/2673013003
Cr-Commit-Position: refs/heads/master@{#449060}
Committed: https://chromium.googlesource.com/chromium/src/+/a792fd2c0899a5798a68993d176cc660af7e33ad

[zakerinasab, 2017-02-03 17:13:46]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions. The
expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions. The
expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

[zakerinasab, 2017-02-03 17:13:46]

zakerinasab@chromium.org changed reviewers:
+ junov@chromium.org

[zakerinasab, 2017-02-03 17:14:02]

CL uploaded. PTAL.

[zakerinasab, 2017-02-06 18:47:57]

On 2017/02/03 17:14:02, zakerinasab wrote:
> CL uploaded. PTAL.

PTAL @ canvas-blending-text.html. After removing the js-test.js, now all the
results are linux are similar to the results on Windows, making the test fail:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/platform/...

[Justin Novosad, 2017-02-07 19:03:39]

The pattern tests are not written correctly.  Because you did not use
async_test, they will not run to completion.

Also, same general comments as with https://codereview.chromium.org/2673883002/

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-blend-solid.html (right):

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blend-solid.html:154: for (var
i = 0; i < blendModes.length; i++) {
Nit: could use generate_tests here

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-image-over-pattern.html
(right):

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-image-over-pattern.html:5:
test(function(t) {
this is supposed to be an async test.

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-image-over-pattern.html:22:
finishJSTest();
t.done()

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-color.html
(right):

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-color.html:7:
testRunner.waitUntilDone();
Get rid of this and use async_test.

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-color.html:26:
finishJSTest();
t.done()

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-gradient.html
(right):

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-gradient.html:5:
test(function(t) {
async

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-gradient.html:22:
return;
you will need t.done() here

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-image.html
(right):

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-image.html:5:
test(function(t) {
async

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-image.html:22:
return;
t.done();

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-pattern.html
(right):

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-pattern.html:5:
test(function(t) {
async

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-pattern.html:22:
return;
t.done

[zakerinasab, 2017-02-07 21:41:28]

Comments addressed.

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-blend-solid.html (right):

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blend-solid.html:154: for (var
i = 0; i < blendModes.length; i++) {
On 2017/02/07 19:03:38, Justin Novosad wrote:
> Nit: could use generate_tests here

Tried this, but makes the code complicated due to the use of loop iterators i
and j in line 178.

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-image-over-pattern.html
(right):

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-image-over-pattern.html:5:
test(function(t) {
On 2017/02/07 19:03:38, Justin Novosad wrote:
> this is supposed to be an async test.

Done.

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-image-over-pattern.html:22:
finishJSTest();
On 2017/02/07 19:03:38, Justin Novosad wrote:
> t.done()

Done. I'll take a quick look at other tests to make sure the same mistake is not
repeated.

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-color.html
(right):

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-color.html:7:
testRunner.waitUntilDone();
On 2017/02/07 19:03:38, Justin Novosad wrote:
> Get rid of this and use async_test.

Done.

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-color.html:26:
finishJSTest();
On 2017/02/07 19:03:38, Justin Novosad wrote:
> t.done()

Done.

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-gradient.html
(right):

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-gradient.html:5:
test(function(t) {
On 2017/02/07 19:03:38, Justin Novosad wrote:
> async

Done.

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-gradient.html:22:
return;
On 2017/02/07 19:03:39, Justin Novosad wrote:
> you will need t.done() here

Done.

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-image.html
(right):

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-image.html:5:
test(function(t) {
On 2017/02/07 19:03:39, Justin Novosad wrote:
> async

Done.

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-image.html:22:
return;
On 2017/02/07 19:03:39, Justin Novosad wrote:
> t.done();

Done.

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-pattern.html
(right):

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-pattern.html:5:
test(function(t) {
On 2017/02/07 19:03:39, Justin Novosad wrote:
> async

Done.

https://codereview.chromium.org/2673013003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-blending-pattern-over-pattern.html:22:
return;
On 2017/02/07 19:03:39, Justin Novosad wrote:
> t.done

Done.

[Justin Novosad, 2017-02-07 22:00:05]

In the async tests, the calls to checkBlendModeResult need to be inside a
t.step() call, otherwise, the testharness will not be able to handle assert
failures correctly.

[zakerinasab, 2017-02-08 17:21:19]

Patchset #5 (id:80001) has been deleted

[zakerinasab, 2017-02-08 17:22:41]

On 2017/02/07 22:00:05, Justin Novosad wrote:
> In the async tests, the calls to checkBlendModeResult need to be inside a
> t.step() call, otherwise, the testharness will not be able to handle assert
> failures correctly.

Fixed. PTAL. Thanks.

[Justin Novosad, 2017-02-08 18:50:37]

lgtm

[zakerinasab, 2017-02-08 19:05:00]

The CQ bit was checked by zakerinasab@chromium.org

[commit-bot: I haz the power, 2017-02-08 19:05:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 19:20:20]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1486580700075520,
"parent_rev": "b7db334e7ee07cf885c57d6b37ecdd7166ecbc1d", "commit_rev":
"a792fd2c0899a5798a68993d176cc660af7e33ad"}

[commit-bot: I haz the power, 2017-02-08 19:21:00]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions. The
expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions. The
expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2673013003
Cr-Commit-Position: refs/heads/master@{#449060}
Committed:
https://chromium.googlesource.com/chromium/src/+/a792fd2c0899a5798a68993d176c...
==========

[commit-bot: I haz the power, 2017-02-08 19:21:01]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/a792fd2c0899a5798a68993d176c...