[Reading List] Display the redirected URL's favicon.

ios/chrome/browser/reading_list/reading_list_distiller_page.h

Index: ios/chrome/browser/reading_list/reading_list_distiller_page.h
diff --git a/ios/chrome/browser/reading_list/reading_list_distiller_page.h b/ios/chrome/browser/reading_list/reading_list_distiller_page.h
index eae2b3afa52db1f7fa2ebfe82776e2275c3c8dce..b9df39afff31fcff1db563660d2ede9c5dd29d0c 100644
--- a/ios/chrome/browser/reading_list/reading_list_distiller_page.h
+++ b/ios/chrome/browser/reading_list/reading_list_distiller_page.h
@@ -82,6 +82,8 @@ class ReadingListDistillerPage : public dom_distiller::DistillerPageIOS {
   // Continue the distillation on the page that is currently loaded in
   // |CurrentWebState()|.
   void ContinuePageDistillation();
+  // Starts the fetching of |page_url|'s favicon.

[stkhapugin, 2017/02/03 10:37:13]

Can you add a test for this?

[Olivier, 2017/02/03 10:44:55]

This is a glue method.
Testing it would require far more than just deleting the method, so If you
prefer, I can just inline it.

[stkhapugin, 2017/02/03 14:48:53]

Sorry, I chose a bad place to leave this comment. I was trying to say: the
behavior of showing the favicon of the page redirected to should probably be
tested in one way or another. I can see how I could've changed this behavior if
I were told to refactor this code 3 years from now. Maybe in egtest for reading
list? Or at least leave some documentation somewhere about this behavior? 

Please don't see this as if I'm trying to stop you from landing this code, I'm
just trying to preserve knowledge that this non-trivial behavior is not lost
over time.  

+  void FetchFavicon(const GURL& page_url);
 
   // Continues distillation by calling superclass |OnLoadURLDone|.
   void DelayedOnLoadURLDone();