[Reading List] Display the redirected URL's favicon.

ios/chrome/browser/reading_list/reading_list_distiller_page.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CHROME_BROWSER_READING_LIST_READING_LIST_DISTILLER_PAGE_H_
 #define IOS_CHROME_BROWSER_READING_LIST_READING_LIST_DISTILLER_PAGE_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 64 matching lines @@
   // HandleGoogleCachedAMPPage will navigate to the iframe containing the actual
   // article page.
   void HandleGoogleCachedAMPPage();
   // Handles the JavaScript response. If the URL of the iframe is returned,
   // triggers a navigation to it. Stop distillation of the page there as the new
   // load will trigger a new distillation.
   bool HandleGoogleCachedAMPPageJavaScriptResult(id result, id error);
   // Continue the distillation on the page that is currently loaded in
   // |CurrentWebState()|.
   void ContinuePageDistillation();
+  // Starts the fetching of |page_url|'s favicon.

[stkhapugin, 2017/02/03 10:37:13]

Can you add a test for this?

[Olivier, 2017/02/03 10:44:55]

This is a glue method.
Testing it would require far more than just deleting the method, so If you
prefer, I can just inline it.

[stkhapugin, 2017/02/03 14:48:53]

Sorry, I chose a bad place to leave this comment. I was trying to say: the
behavior of showing the favicon of the page redirected to should probably be
tested in one way or another. I can see how I could've changed this behavior if
I were told to refactor this code 3 years from now. Maybe in egtest for reading
list? Or at least leave some documentation somewhere about this behavior? 

Please don't see this as if I'm trying to stop you from landing this code, I'm
just trying to preserve knowledge that this non-trivial behavior is not lost
over time.  

+  void FetchFavicon(const GURL& page_url);
 
   // Continues distillation by calling superclass |OnLoadURLDone|.
   void DelayedOnLoadURLDone();
   GURL original_url_;
 
   FaviconWebStateDispatcher* web_state_dispatcher_;
   ReadingListDistillerPageDelegate* delegate_;
   base::WeakPtrFactory<ReadingListDistillerPage> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ReadingListDistillerPage);
 };
 
 }  // namespace reading_list
 
 #endif  // IOS_CHROME_BROWSER_READING_LIST_READING_LIST_DISTILLER_PAGE_H_