Fix clip caching bug in GeometryMapper.

Fix caching bug in GeometryMapper.

There can be multiple clip spaces within the same transform space. We need
a separate cache for each.

BUG=683733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2672993004
Cr-Commit-Position: refs/heads/master@{#448325}
Committed: https://chromium.googlesource.com/chromium/src/+/25c670f083721a982eb4b7aa01d06beaf888365e

[chrishtr, 2017-02-04 20:16:06]

Description was changed from

==========
none


none

BUG=
==========

to

==========
none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-02-04 20:17:51]

Description was changed from

==========
none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix caching bug in GeometryMapper.

There can be multiple clip spaces within the same transform space. We need
a separate cache for each.

BUG=683733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-02-04 20:39:45]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[chrishtr, 2017-02-04 20:39:46]

I originally encountered this due to a PaintLayerClipper test failure
PaintLayerClipperTest.NestedContainPaintClip. In this test we compute
clip rects relative to the same ancestor twice, once without the
overflow clip of the ancestor and once with. Previously, this test
did not exercise the cache because every time the clipper() object
was queried, it used a new instance of GeometryMapper. With my
in-progress CL to re-use it in PaintLayerClippper, I therefore
encountered this bug.

I think one reason this was not discovered earlier in the
PaintInvalidator use case is because it always uses the same destination
clip state for a paintInvalidationContainer, and the different
paintInvalidaitonContainers tend to be in different transform+clip
 spaces in the tests.

[chrishtr, 2017-02-04 20:39:53]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 20:40:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 22:40:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 22:40:35]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_TIMED_OUT,
no build URL)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no
build URL)
  win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)

[Xianzhu, 2017-02-05 02:03:45]

lgtm

https://codereview.chromium.org/2672993004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h (right):

https://codereview.chromium.org/2672993004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h:39: };
Nit: Move the above types into private section of Geometry?

[chrishtr, 2017-02-06 16:56:48]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 16:57:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-02-06 16:57:42]

On 2017/02/05 at 02:03:45, wangxianzhu wrote:
> lgtm
> 
>
https://codereview.chromium.org/2672993004/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h
(right):
> 
>
https://codereview.chromium.org/2672993004/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h:39: };
> Nit: Move the above types into private section of Geometry?

I'll do that in a followup.

[chrishtr, 2017-02-06 16:57:48]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-02-06 16:57:49]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-02-06 16:58:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 18:46:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486400269979780, "parent_rev":
"38b110ec3981062d81c3e61a3a0508eee0f2f1c2", "commit_rev":
"25c670f083721a982eb4b7aa01d06beaf888365e"}

[commit-bot: I haz the power, 2017-02-06 18:47:26]

Description was changed from

==========
Fix caching bug in GeometryMapper.

There can be multiple clip spaces within the same transform space. We need
a separate cache for each.

BUG=683733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix caching bug in GeometryMapper.

There can be multiple clip spaces within the same transform space. We need
a separate cache for each.

BUG=683733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2672993004
Cr-Commit-Position: refs/heads/master@{#448325}
Committed:
https://chromium.googlesource.com/chromium/src/+/25c670f083721a982eb4b7aa01d0...
==========

[commit-bot: I haz the power, 2017-02-06 18:47:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25c670f083721a982eb4b7aa01d0...