Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2672913002:
[Mac] Fix fullscreen tabstrip animation (Closed)
|
Created:
3 years, 10 months ago by spqchan Modified:
3 years, 10 months ago Reviewers:
Robert Sesek CC:
chromium-reviews, mac-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Mac] Fix for fullscreen tabstrip animation
Fix for an issue where the tabstrip animates out when you're still
cycling between tabs.
BUG=591776
Review-Url: https://codereview.chromium.org/2672913002
Cr-Commit-Position: refs/heads/master@{#448014}
Committed: https://chromium.googlesource.com/chromium/src/+/d8fafb98e8e3a3829e6671432e2e5782242d9121
Patch Set 1 : . #
Messages
Total messages: 20 (15 generated)
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Mac] Fix fullscreen tabstrip animation BUG=591776 ========== to ========== [Mac] Fix for fullscreen tabstrip animation Fix for an issue where the tabstrip animates out when you're still cycling between tabs. BUG=591776 ==========
spqchan@chromium.org changed reviewers: + rsesek@chromium.org
PTAL
lgtm
On 2017/02/03 10:42:32, Robert Sesek wrote: > lgtm thanks!
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486141172079410,
"parent_rev": "a80d18c3fa89a2cc0b7c01a22a6aa1df796f550d", "commit_rev":
"d8fafb98e8e3a3829e6671432e2e5782242d9121"}
Message was sent while issue was closed.
Description was changed from ========== [Mac] Fix for fullscreen tabstrip animation Fix for an issue where the tabstrip animates out when you're still cycling between tabs. BUG=591776 ========== to ========== [Mac] Fix for fullscreen tabstrip animation Fix for an issue where the tabstrip animates out when you're still cycling between tabs. BUG=591776 Review-Url: https://codereview.chromium.org/2672913002 Cr-Commit-Position: refs/heads/master@{#448014} Committed: https://chromium.googlesource.com/chromium/src/+/d8fafb98e8e3a3829e6671432e2e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as https://chromium.googlesource.com/chromium/src/+/d8fafb98e8e3a3829e6671432e2e... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
