Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2672883002: Change chrome debug dbus client to sent ppd contents as an array of bytes. (Closed)

Created:
3 years, 10 months ago by Carlson
Modified:
3 years, 10 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change chrome debug dbus client to sent ppd contents as an array of bytes. Previously it was using a string. But dbus requires that strings in messages be UTF-8 valid, so this breaks when we try to send gzipped data over the wire. Note that debugd has already been updated to use ArrayOfBytes instead of String. BUG=chromium:684062 Review-Url: https://codereview.chromium.org/2672883002 Cr-Commit-Position: refs/heads/master@{#447852} Committed: https://chromium.googlesource.com/chromium/src/+/c543690b8b9b0e69783ec8304819aba1971977f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chromeos/dbus/debug_daemon_client.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Carlson
I missed propagating this update to the client when we fixed the issue in debugd. ...
3 years, 10 months ago (2017-02-02 19:44:07 UTC) #3
stevenjb
lgtm
3 years, 10 months ago (2017-02-02 21:30:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672883002/1
3 years, 10 months ago (2017-02-02 21:51:10 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 21:57:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c543690b8b9b0e69783ec8304819...

Powered by Google App Engine
This is Rietveld 408576698