Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html

Issue 2672863007: Convert Panner distance model tests to testharness (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html b/third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html
index b1a07da242f0009d7631436de5d38c58ae157838..75810a9011108c909f0aa20abfc9f8279bc7f893 100644
--- a/third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html
+++ b/third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html
@@ -1,36 +1,27 @@
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
Raymond Toy 2017/02/14 20:14:17 Should I fix these?
hongchan 2017/02/17 18:31:04 Since this is manual change I would say yes. :) <
Raymond Toy 2017/02/17 19:10:11 Done.
<html>
<head>
- <script src="../../resources/js-test.js"></script>
+ <script src="../../resources/testharness.js"></script>
+ <script src="../../resources/testharnessreport.js"></script>
<script src="../resources/audit-util.js"></script>
- <script src="../resources/audio-testing.js"></script>
+ <script src="../resources/audit.js"></script>
<script src="../resources/distance-model-testing.js"></script>
</head>
<body>
- <div id="description"></div>
- <div id="console"></div>
-
<script>
- description("Test exponential distance model of AudioPannerNode.");
-
- function runTest() {
- if (window.testRunner) {
- testRunner.dumpAsText();
- testRunner.waitUntilDone();
- }
-
- window.jsTestIsAsync = true;
+ let audit = Audit.createTaskRunner();
+ audit.define("test", function (task, should) {
+ task.describe("Exponential distance model for PannerNode");
// Create offline audio context.
context = new OfflineAudioContext(2, sampleRate * renderLengthSeconds, sampleRate);
- createTestAndRun(context, "exponential");
- }
-
- runTest();
- successfullyParsed = true;
+ createTestAndRun(context, "exponential", should)
+ .then(task.done.bind(task));
+ });
+ audit.run();
</script>
</body>

Powered by Google App Engine
This is Rietveld 408576698