Chromium Code Reviews Chromium Code Reviews
Issue 2672863007:
Convert Panner distance model tests to testharness (Closed)
| Index: third_party/WebKit/LayoutTests/webaudio/Panner/distance-inverse.html |
| diff --git a/third_party/WebKit/LayoutTests/webaudio/Panner/distance-inverse.html b/third_party/WebKit/LayoutTests/webaudio/Panner/distance-inverse.html |
| index 49b7c3fecd0c9bc5384cf43b1e4ac19efc123014..67596abbdb7b3140b823f694458f9ff1c7c26a7d 100644 |
| --- a/third_party/WebKit/LayoutTests/webaudio/Panner/distance-inverse.html |
| +++ b/third_party/WebKit/LayoutTests/webaudio/Panner/distance-inverse.html |
| @@ -1,36 +1,26 @@ |
| <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> |
| <html> |
| <head> |
| - <script src="../../resources/js-test.js"></script> |
| + <script src="../../resources/testharness.js"></script> |
| + <script src="../../resources/testharnessreport.js"></script> |
| <script src="../resources/audit-util.js"></script> |
| - <script src="../resources/audio-testing.js"></script> |
| + <script src="../resources/audit.js"></script> |
| <script src="../resources/distance-model-testing.js"></script> |
| </head> |
| <body> |
| - <div id="description"></div> |
| - <div id="console"></div> |
| - |
| <script> |
| - description("Test inverse distance model of AudioPannerNode."); |
| - |
| - function runTest() { |
| - if (window.testRunner) { |
| - testRunner.dumpAsText(); |
| - testRunner.waitUntilDone(); |
| - } |
| - |
| - window.jsTestIsAsync = true; |
| + let audit = Audit.createTaskRunner(); |
| + audit.define("test", function (task, should) { |
|
hongchan
2017/02/17 18:31:04
Use single quote and use () => notation.
Raymond Toy
2017/02/17 19:10:11
The rest of the file uses double, so I won't chang
|
| // Create offline audio context. |
| context = new OfflineAudioContext(2, sampleRate * renderLengthSeconds, sampleRate); |
| - createTestAndRun(context, "inverse"); |
| - } |
| - |
| - runTest(); |
| - successfullyParsed = true; |
| + createTestAndRun(context, "inverse", should) |
| + .then(task.done.bind(task)); |
|
hongchan
2017/02/17 18:31:04
.then(() => task.done());
Raymond Toy
2017/02/17 19:10:11
Done.
|
| + }); |
| + audit.run(); |
| </script> |
| </body> |
