Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2672863007: Convert Panner distance model tests to testharness (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Panner distance model tests to testharness Manually convert distance model test to use testharness and new Audit. BUG=688456 TEST=distance-*.html Review-Url: https://codereview.chromium.org/2672863007 Cr-Commit-Position: refs/heads/master@{#452186} Committed: https://chromium.googlesource.com/chromium/src/+/b567949e5de163c4e5af1aba7dd1fb645a723d93

Patch Set 1 #

Total comments: 16

Patch Set 2 : Address review comments #

Total comments: 8

Patch Set 3 : Reindent according to review #

Messages

Total messages: 14 (4 generated)
Raymond Toy
PTAL https://codereview.chromium.org/2672863007/diff/1/third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html File third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html (right): https://codereview.chromium.org/2672863007/diff/1/third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html#newcode1 third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html:1: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> Should ...
3 years, 10 months ago (2017-02-14 20:14:17 UTC) #2
hongchan
https://codereview.chromium.org/2672863007/diff/1/third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html File third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html (right): https://codereview.chromium.org/2672863007/diff/1/third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html#newcode1 third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html:1: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> On 2017/02/14 ...
3 years, 10 months ago (2017-02-17 18:31:04 UTC) #3
Raymond Toy
https://codereview.chromium.org/2672863007/diff/1/third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html File third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html (right): https://codereview.chromium.org/2672863007/diff/1/third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html#newcode1 third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html:1: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> On 2017/02/17 ...
3 years, 10 months ago (2017-02-17 19:10:12 UTC) #4
hongchan
Looks good in general, but we have to talk about some weird results from clang-format. ...
3 years, 10 months ago (2017-02-21 17:14:20 UTC) #5
Raymond Toy
https://codereview.chromium.org/2672863007/diff/20001/third_party/WebKit/LayoutTests/webaudio/resources/distance-model-testing.js File third_party/WebKit/LayoutTests/webaudio/resources/distance-model-testing.js (right): https://codereview.chromium.org/2672863007/diff/20001/third_party/WebKit/LayoutTests/webaudio/resources/distance-model-testing.js#newcode154 third_party/WebKit/LayoutTests/webaudio/resources/distance-model-testing.js:154: position[impulseCount]); On 2017/02/21 17:14:20, hongchan wrote: > Is this ...
3 years, 10 months ago (2017-02-21 17:38:38 UTC) #6
hongchan
https://codereview.chromium.org/2672863007/diff/20001/third_party/WebKit/LayoutTests/webaudio/resources/distance-model-testing.js File third_party/WebKit/LayoutTests/webaudio/resources/distance-model-testing.js (right): https://codereview.chromium.org/2672863007/diff/20001/third_party/WebKit/LayoutTests/webaudio/resources/distance-model-testing.js#newcode154 third_party/WebKit/LayoutTests/webaudio/resources/distance-model-testing.js:154: position[impulseCount]); On 2017/02/21 17:38:38, Raymond Toy wrote: > On ...
3 years, 10 months ago (2017-02-22 18:51:06 UTC) #7
Raymond Toy
https://codereview.chromium.org/2672863007/diff/20001/third_party/WebKit/LayoutTests/webaudio/resources/distance-model-testing.js File third_party/WebKit/LayoutTests/webaudio/resources/distance-model-testing.js (right): https://codereview.chromium.org/2672863007/diff/20001/third_party/WebKit/LayoutTests/webaudio/resources/distance-model-testing.js#newcode154 third_party/WebKit/LayoutTests/webaudio/resources/distance-model-testing.js:154: position[impulseCount]); On 2017/02/22 18:51:06, hongchan wrote: > On 2017/02/21 ...
3 years, 10 months ago (2017-02-22 19:02:20 UTC) #8
hongchan
lgtm
3 years, 10 months ago (2017-02-22 19:06:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672863007/40001
3 years, 10 months ago (2017-02-22 19:33:40 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 20:40:37 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b567949e5de163c4e5af1aba7dd1...

Powered by Google App Engine
This is Rietveld 408576698