Invalidate width available to children if style diff needs full layout

Invalidate width available to children if style diff needs full layout

The existing logic is too strict: it only invalidates the width
available to children if the border/padding has changed.  Whenever
the style diff requires full layout, we should assume that the width
available to children might change.

BUG=387290
R=eae@chromium.org,esprehn@chromium.org

Review-Url: https://codereview.chromium.org/2672833004
Cr-Commit-Position: refs/heads/master@{#448732}
Committed: https://chromium.googlesource.com/chromium/src/+/7b1e0cb2db282469b4b81f47d40ab45132a7ec0f

[szager1, 2017-02-03 20:56:54]

The CQ bit was checked by szager@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 20:57:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 22:39:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 22:39:39]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[szager1, 2017-02-07 06:47:53]

The CQ bit was checked by szager@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 06:48:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[szager1, 2017-02-07 06:54:05]

Notes about test tweaks:

- media/track/track-cue-rendering-after-controls-removed.html has some built-in
flakiness; filed crbug.com/688670 to track.

- paint/invalidation/button-inner-no-repaint.html caused invalidations because
when line layout runs on the button text after the style change, it hits this
code:

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/La...

So, even though the text didn't change, the last line is marked as dirty because
it didn't break cleanly.  Adding <br> to the end of the button text makes it
pass.

[commit-bot: I haz the power, 2017-02-07 09:00:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 09:00:41]

Dry run: This issue passed the CQ dry run.

[eae, 2017-02-07 17:42:24]

Not super familiar with that code but I doubt anyone is at this stage. It
certainly seems more correct.

I like the test.

LGTM

[szager1, 2017-02-07 18:31:31]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2017-02-07 18:32:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 18:38:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 18:38:16]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:2344
  error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
5bd5568d00b773258fb7ea36aeeef4f02bf3f62d..099b9525f93dbdfe65e61b94dd7827650d9ecd88
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -2344,6 +2344,8 @@ crbug.com/664844
media/track/track-kind-user-preference.html [ Pass Failure ]
 crbug.com/664855
virtual/scroll_customization/fast/scroll-behavior/main-frame-interrupted-scroll.html
[ Pass Failure ]
 crbug.com/664856 virtual/sharedarraybuffer/fast/workers/worker-gc.html [ Pass
Failure ]
 
+crbug.com/688670 media/track/track-cue-rendering-after-controls-removed.html [
Pass Failure ]
+
 # Possible duplicate of crbug.com/665577
 # crbug.com/664858
virtual/threaded/fast/scroll-behavior/overflow-scroll-animates.html [ Pass
Failure ]
 # crbug.com/664858
virtual/threaded/fast/scroll-behavior/smooth-scroll/horizontal-smooth-scroll-in-rtl.html
[ Pass Failure ]

[szager1, 2017-02-07 19:58:24]

The CQ bit was checked by szager@chromium.org

[szager1, 2017-02-07 19:58:24]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2672833004/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-07 19:59:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 22:07:58]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486497504300490,
"parent_rev": "c405416053b99aa4d6f98f3126608c660773f6b4", "commit_rev":
"7b1e0cb2db282469b4b81f47d40ab45132a7ec0f"}

[commit-bot: I haz the power, 2017-02-07 22:08:34]

Description was changed from

==========
Invalidate width available to children if style diff needs full layout

The existing logic is too strict: it only invalidates the width
available to children if the border/padding has changed.  Whenever
the style diff requires full layout, we should assume that the width
available to children might change.

BUG=387290
R=eae@chromium.org,esprehn@chromium.org
==========

to

==========
Invalidate width available to children if style diff needs full layout

The existing logic is too strict: it only invalidates the width
available to children if the border/padding has changed.  Whenever
the style diff requires full layout, we should assume that the width
available to children might change.

BUG=387290
R=eae@chromium.org,esprehn@chromium.org

Review-Url: https://codereview.chromium.org/2672833004
Cr-Commit-Position: refs/heads/master@{#448732}
Committed:
https://chromium.googlesource.com/chromium/src/+/7b1e0cb2db282469b4b81f47d40a...
==========

[commit-bot: I haz the power, 2017-02-07 22:08:34]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7b1e0cb2db282469b4b81f47d40a...