Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2672823003: Rename ReadingListViewController to ReadingListCollectionViewController (Closed)

Created:
3 years, 10 months ago by gambard
Modified:
3 years, 10 months ago
Reviewers:
stkhapugin, Olivier, jif
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ReadingListViewController to ReadingListCollectionViewController BUG=688392 Review-Url: https://codereview.chromium.org/2672823003 Cr-Commit-Position: refs/heads/master@{#448329} Committed: https://chromium.googlesource.com/chromium/src/+/06742d0d6225a9b04cb79a1204630f9b828cedd2

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Patch Set 3 : Fix tests #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -1518 lines) Patch
M ios/chrome/browser/ui/reading_list/BUILD.gn View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.h View 1 4 chunks +27 lines, -20 lines 0 comments Download
A + ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm View 1 2 3 11 chunks +19 lines, -15 lines 0 comments Download
A + ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm View 1 2 6 chunks +22 lines, -19 lines 0 comments Download
D ios/chrome/browser/ui/reading_list/reading_list_view_controller.h View 1 chunk +0 lines, -78 lines 0 comments Download
D ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm View 1 2 3 1 chunk +0 lines, -1157 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.mm View 1 2 3 12 chunks +60 lines, -49 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_view_controller_container_unittest.mm View 1 2 3 4 chunks +8 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_view_controller_unittest.mm View 1 1 chunk +0 lines, -168 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
gambard
PTAL/FYI
3 years, 10 months ago (2017-02-03 15:45:10 UTC) #2
Olivier
https://codereview.chromium.org/2672823003/diff/1/ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.h File ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.h (right): https://codereview.chromium.org/2672823003/diff/1/ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.h#newcode17 ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.h:17: @class ReadingListCollectionViewController; should be before (alphabetical order). https://codereview.chromium.org/2672823003/diff/1/ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.mm File ...
3 years, 10 months ago (2017-02-03 15:52:11 UTC) #3
gambard
Thanks, PTAL. https://codereview.chromium.org/2672823003/diff/1/ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.h File ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.h (right): https://codereview.chromium.org/2672823003/diff/1/ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.h#newcode17 ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.h:17: @class ReadingListCollectionViewController; On 2017/02/03 15:52:11, Olivier Robin ...
3 years, 10 months ago (2017-02-03 15:58:56 UTC) #4
stkhapugin
lgtm \o/
3 years, 10 months ago (2017-02-03 16:37:34 UTC) #5
jif
lgtm
3 years, 10 months ago (2017-02-06 08:29:44 UTC) #6
Olivier
lgtm
3 years, 10 months ago (2017-02-06 08:32:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672823003/60001
3 years, 10 months ago (2017-02-06 17:21:43 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 18:55:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/06742d0d6225a9b04cb79a120463...

Powered by Google App Engine
This is Rietveld 408576698