Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: tools/chrome_proxy/live_tests/chrome_proxy_measurements.py

Issue 2672803002: [Telemetry refactor] Migrate clients to new JavaScript API (batch 3) (Closed)
Patch Set: add comment on tools/android Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/chrome_proxy/live_tests/chrome_proxy_measurements.py
diff --git a/tools/chrome_proxy/live_tests/chrome_proxy_measurements.py b/tools/chrome_proxy/live_tests/chrome_proxy_measurements.py
index 4b9fe6756ad92ff710e4a5b4faf995d3f2c88f8d..a3174040a537cc334ba33b8681d1abfcfdc881db 100644
--- a/tools/chrome_proxy/live_tests/chrome_proxy_measurements.py
+++ b/tools/chrome_proxy/live_tests/chrome_proxy_measurements.py
@@ -22,7 +22,8 @@ class ChromeProxyLatencyBase(legacy_page_test.LegacyPageTest):
def ValidateAndMeasurePage(self, page, tab, results):
# Wait for the load event.
- tab.WaitForJavaScriptExpression('performance.timing.loadEventStart', 300)
+ tab.WaitForJavaScriptCondition2(
+ 'performance.timing.loadEventStart', timeout=300)
self._metrics.Stop(page, tab)
self._metrics.AddResultsForLatency(tab, results)
@@ -61,7 +62,8 @@ class ChromeProxyDataSavingBase(legacy_page_test.LegacyPageTest):
def ValidateAndMeasurePage(self, page, tab, results):
# Wait for the load event.
- tab.WaitForJavaScriptExpression('performance.timing.loadEventStart', 300)
+ tab.WaitForJavaScriptCondition2(
+ 'performance.timing.loadEventStart', timeout=300)
self._metrics.Stop(page, tab)
self._metrics.AddResultsForDataSaving(tab, results)

Powered by Google App Engine
This is Rietveld 408576698