tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/pass_through.py - Issue 2672803002: [Telemetry refactor] Migrate clients to new JavaScript API (batch 3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/pass_through.py

Issue 2672803002: [Telemetry refactor] Migrate clients to new JavaScript API (batch 3) (Closed)

Patch Set: add comment on tools/android Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py ('k') | tools/chrome_proxy/live_tests/chrome_proxy_measurements.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/pass_through.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/pass_through.py b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/pass_through.py

index c19cfc3e73e7f82616a7aab49bb037605202ba6c..cecba7044bb26244deb56f0713ed4147098a8932 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/pass_through.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/pass_through.py

@@ -17,13 +17,13 @@ class PassThroughPage(page_module.Page):

def RunNavigateSteps(self, action_runner):

super(PassThroughPage, self).RunNavigateSteps(action_runner)

- action_runner.ExecuteJavaScript('''

+ action_runner.ExecuteJavaScript2('''

(function() {

var request = new XMLHttpRequest();

- request.open("GET", "%s");

+ request.open("GET", {{ url }});

request.setRequestHeader("Chrome-Proxy-Accept-Transform", "identity");

request.send(null);

- })();''' % (self.url))

+ })();''', url=self.url)

action_runner.Wait(1)