Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 2672763002: [turbofan] Remove frame-state from {JSConvertReceiver}. (Closed)

Created:
3 years, 10 months ago by Michael Starzinger
Modified:
3 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove frame-state from {JSConvertReceiver}. The operator in question does not call arbitrary JavaSciprt, nor throw, nor trigger a lazy deoptimization. Nodes hence do not need a frame-state representing the "after" state of the operation. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2672763002 Cr-Commit-Position: refs/heads/master@{#42891} Committed: https://chromium.googlesource.com/v8/v8/+/d0edd08eb5e89c1e2c1bd336adfc3362eae18d35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -22 lines) Patch
M src/compiler/js-inlining.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Michael Starzinger
3 years, 10 months ago (2017-02-02 13:43:39 UTC) #7
Benedikt Meurer
lgtm
3 years, 10 months ago (2017-02-02 13:50:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672763002/1
3 years, 10 months ago (2017-02-02 13:58:09 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 14:00:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d0edd08eb5e89c1e2c1bd336adfc3362eae...

Powered by Google App Engine
This is Rietveld 408576698