android: Fix crash in blink::LayoutText::localCaretRect()

android: Fix crash in blink::LayoutText::localCaretRect()

We need to check if primaryFont() returns null.

BUG=687701
Review-Url: https://codereview.chromium.org/2672743002
Cr-Commit-Position: refs/heads/master@{#447876}
Committed: https://chromium.googlesource.com/chromium/src/+/a7a6fb7570da5886caa2befd40295ca7b52f79ac

[joone, 2017-02-02 09:17:51]

Description was changed from

==========
android: Fix crash in blink::LayoutText::localCaretRect()

BUG=687701
==========

to

==========
android: Fix crash in blink::LayoutText::localCaretRect()

We need to check if primaryFont() returns null.

BUG=687701
==========

[joone, 2017-02-02 09:18:10]

The CQ bit was checked by joone.hur@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 09:18:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joone, 2017-02-02 09:21:08]

joone.hur@intel.com changed reviewers:
+ tkent@chromium.org

[joone, 2017-02-02 09:21:09]

Hi tkent@, could you review this CL?

[commit-bot: I haz the power, 2017-02-02 10:45:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 10:45:12]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-02-02 23:18:04]

tkent@chromium.org changed reviewers:
+ eae@chromium.org, kojii@chromium.org

[tkent, 2017-02-02 23:19:07]

I'm not sure if we should handle null primaryFont() here, or somewhere else.
eae@, kojii@, do you have any opinions?

[eae, 2017-02-02 23:24:36]

It *should* never be null but sadly can be so always checking before using it is
the right thing to do.

LGTM

[eae, 2017-02-02 23:25:47]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-02-02 23:26:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 23:34:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486077947249160, "parent_rev":
"6b08b5d1106a7faa33f2dbb8c07ac9ba67058e16", "commit_rev":
"a7a6fb7570da5886caa2befd40295ca7b52f79ac"}

[commit-bot: I haz the power, 2017-02-02 23:35:04]

Description was changed from

==========
android: Fix crash in blink::LayoutText::localCaretRect()

We need to check if primaryFont() returns null.

BUG=687701
==========

to

==========
android: Fix crash in blink::LayoutText::localCaretRect()

We need to check if primaryFont() returns null.

BUG=687701

Review-Url: https://codereview.chromium.org/2672743002
Cr-Commit-Position: refs/heads/master@{#447876}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7a6fb7570da5886caa2befd4029...
==========

[commit-bot: I haz the power, 2017-02-02 23:35:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a7a6fb7570da5886caa2befd4029...