[MD History] Disable Clear Browsing Data button for supervised users.

[MD History] Hide selection and deletion UI for users that can't delete history.

BUG=687539
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2672723002
Cr-Commit-Position: refs/heads/master@{#450861}
Committed: https://chromium.googlesource.com/chromium/src/+/9fad3677dfb44803f01ad43c92b9dc1a82b40794

[calamity, 2017-02-02 07:07:33]

Description was changed from

==========
[MD History] Disable Clear Browsing Data button for supervised users.

BUG=687539
==========

to

==========
[MD History] Disable Clear Browsing Data button for supervised users.

BUG=687539
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2017-02-02 07:09:54]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[calamity, 2017-02-02 07:10:00]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[commit-bot: I haz the power, 2017-02-02 07:10:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 07:21:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 07:21:11]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Dan Beam, 2017-02-02 07:43:11]

https://codereview.chromium.org/2672723002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/side_bar.js (right):

https://codereview.chromium.org/2672723002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/side_bar.js:16: showFooter: Boolean,
nit: this could be a property instead?

deletingAllowed_: {
  type: Boolean,
  value: function() {
    return loadTimeData.getBoolean('allowDeletingHistory');
  },
},

[tsergeant, 2017-02-03 00:34:50]

https://codereview.chromium.org/2672723002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/side_bar.js (right):

https://codereview.chromium.org/2672723002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/side_bar.js:16: showFooter: Boolean,
On 2017/02/02 07:43:11, Dan Beam (slow) wrote:
> nit: this could be a property instead?
> 
> deletingAllowed_: {
>   type: Boolean,
>   value: function() {
>     return loadTimeData.getBoolean('allowDeletingHistory');
>   },
> },

Seems like a better pattern -- we should probably do this in item.html/js as
well.

[calamity, 2017-02-07 05:07:45]

Patchset #2 (id:20001) has been deleted

[calamity, 2017-02-07 05:08:59]

https://codereview.chromium.org/2672723002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/side_bar.js (right):

https://codereview.chromium.org/2672723002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/side_bar.js:16: showFooter: Boolean,
On 2017/02/03 00:34:50, tsergeant wrote:
> On 2017/02/02 07:43:11, Dan Beam (slow) wrote:
> > nit: this could be a property instead?
> > 
> > deletingAllowed_: {
> >   type: Boolean,
> >   value: function() {
> >     return loadTimeData.getBoolean('allowDeletingHistory');
> >   },
> > },
> 
> Seems like a better pattern -- we should probably do this in item.html/js as
> well.

Done.

[calamity, 2017-02-07 05:09:03]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 05:09:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 05:11:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 05:11:01]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[calamity, 2017-02-07 06:58:31]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 06:58:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 08:06:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 08:06:30]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-02-08 00:14:06]

On 2017/02/07 05:08:59, calamity wrote:
>
https://codereview.chromium.org/2672723002/diff/1/chrome/browser/resources/md...
> File chrome/browser/resources/md_history/side_bar.js (right):
> 
>
https://codereview.chromium.org/2672723002/diff/1/chrome/browser/resources/md...
> chrome/browser/resources/md_history/side_bar.js:16: showFooter: Boolean,
> On 2017/02/03 00:34:50, tsergeant wrote:
> > On 2017/02/02 07:43:11, Dan Beam (slow) wrote:
> > > nit: this could be a property instead?
> > > 
> > > deletingAllowed_: {
> > >   type: Boolean,
> > >   value: function() {
> > >     return loadTimeData.getBoolean('allowDeletingHistory');
> > >   },
> > > },
> > 
> > Seems like a better pattern -- we should probably do this in item.html/js as
> > well.
> 
> Done.

As discussed in person, I don't think this change is actually necessary.
However, the bug suggests hiding the (already) disabled checkbox/menu items, and
that seems like a reasonable change to make.

[calamity, 2017-02-08 05:51:45]

Description was changed from

==========
[MD History] Disable Clear Browsing Data button for supervised users.

BUG=687539
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Hide selection and deletion UI for users that can't delete history.

BUG=687539
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-02-09 03:27:07]

lgtm

[calamity, 2017-02-13 02:41:08]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 02:41:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 03:31:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 03:31:57]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[calamity, 2017-02-15 04:00:58]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 04:02:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 04:07:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 04:07:22]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[calamity, 2017-02-15 05:57:52]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 05:58:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 07:02:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 07:02:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[calamity, 2017-02-15 07:12:15]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 07:12:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 08:28:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 08:28:15]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-02-16 00:29:27]

The CQ bit was checked by calamity@chromium.org

[calamity, 2017-02-16 00:29:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2672723002/#ps140001
(title: "fix_test")

[commit-bot: I haz the power, 2017-02-16 00:30:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 02:34:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 02:34:51]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[calamity, 2017-02-16 03:00:28]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2017-02-16 03:01:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 03:31:36]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1487214028284470,
"parent_rev": "ab1bf635d077f765c43a498d0b95034e2d564b4b", "commit_rev":
"9fad3677dfb44803f01ad43c92b9dc1a82b40794"}

[commit-bot: I haz the power, 2017-02-16 03:34:13]

Description was changed from

==========
[MD History] Hide selection and deletion UI for users that can't delete history.

BUG=687539
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Hide selection and deletion UI for users that can't delete history.

BUG=687539
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2672723002
Cr-Commit-Position: refs/heads/master@{#450861}
Committed:
https://chromium.googlesource.com/chromium/src/+/9fad3677dfb44803f01ad43c92b9...
==========

[commit-bot: I haz the power, 2017-02-16 03:34:15]

Committed patchset #7 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/9fad3677dfb44803f01ad43c92b9...