Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2672713003: Fix Kernel tests (Closed)

Created:
3 years, 10 months ago by Kevin Millikin (Google)
Modified:
3 years, 10 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Kernel tests Splitting transformations into modular and global ones needs to be implemented in the tests. BUG= R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/f9cd5274f511ca267e685e6b1145ec806b64f4a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M pkg/kernel/test/baseline_spec_mode_test.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/kernel/test/baseline_strong_mode_test.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M pkg/kernel/test/baseline_tester.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/kernel/test/baseline_type_propagation_test.dart View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
As before, I've only made mixin resolution into an officially modular transformation.
3 years, 10 months ago (2017-02-02 13:09:33 UTC) #2
asgerf
lgtm
3 years, 10 months ago (2017-02-02 13:10:19 UTC) #3
Kevin Millikin (Google)
3 years, 10 months ago (2017-02-02 13:12:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f9cd5274f511ca267e685e6b1145ec806b64f4a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698