Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: pkg/kernel/test/baseline_tester.dart

Issue 2672713003: Fix Kernel tests (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/test/baseline_strong_mode_test.dart ('k') | pkg/kernel/test/baseline_type_propagation_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/test/baseline_tester.dart
diff --git a/pkg/kernel/test/baseline_tester.dart b/pkg/kernel/test/baseline_tester.dart
index b954e20197a40f31e39d252b4a42b04a599d87b6..b71870a02d6cc31f17c71f82a5777111a3706401 100644
--- a/pkg/kernel/test/baseline_tester.dart
+++ b/pkg/kernel/test/baseline_tester.dart
@@ -24,7 +24,9 @@ abstract class TestTarget extends Target {
/// Annotations to apply on the textual output.
Annotator get annotator => null;
- List<String> transformProgram(Program program);
+ // Return a list of strings so that we can accumulate errors.
+ List<String> performModularTransformations(Program program);
+ List<String> performGlobalTransformations(Program program);
}
void runBaselineTests(String folderName, TestTarget target) {
@@ -52,7 +54,9 @@ void runBaselineTests(String folderName, TestTarget target) {
applicationRoot: applicationRoot));
var program = loader.loadProgram(dartPath, target: target);
verifyProgram(program);
- var errors = target.transformProgram(program);
+ var errors = target.performModularTransformations(program);
+ verifyProgram(program);
+ errors.addAll(target.performGlobalTransformations(program));
verifyProgram(program);
var buffer = new StringBuffer();
« no previous file with comments | « pkg/kernel/test/baseline_strong_mode_test.dart ('k') | pkg/kernel/test/baseline_type_propagation_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698