Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2672713002: [turbofan] Guard invariant that Branch/Select condition must be Boolean. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Guard invariant that Branch/Select condition must be Boolean. This introduces additional verification logic to ensure that the condition passed to Branch/Select operators is always of type Boolean. CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win64_dbg TBR=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2672713002 Cr-Commit-Position: refs/heads/master@{#42875} Committed: https://chromium.googlesource.com/v8/v8/+/ed3834db3d3cc3f0fd3dfe50277c4c33b7d802da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
Benedikt Meurer
3 years, 10 months ago (2017-02-02 05:27:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672713002/1
3 years, 10 months ago (2017-02-02 05:27:23 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 06:01:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ed3834db3d3cc3f0fd3dfe50277c4c33b7d...

Powered by Google App Engine
This is Rietveld 408576698