Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2672663002: Move DeviceLight out from fast/dom/. (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
riju_
CC:
blink-reviews, chromium-reviews, mlamouri+watch-blink_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move DeviceLight out from fast/dom/. BUG=685886 TBR=rijubrata.bhaumik@intel.com Review-Url: https://codereview.chromium.org/2672663002 Cr-Commit-Position: refs/heads/master@{#447704} Committed: https://chromium.googlesource.com/chromium/src/+/26df0a66691fd1d8d451a1dc701ae4682569a676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -284 lines) Patch
A + third_party/WebKit/LayoutTests/ambient-light/add-listener.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/ambient-light/add-listener-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/ambient-light/create-event.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/ambient-light/create-event-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/ambient-light/multiple-event-listeners.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/ambient-light/multiple-event-listeners-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/ambient-light/page-visibility.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/ambient-light/page-visibility-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/ambient-light/window-property.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/ambient-light/window-property-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceLight/add-listener.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceLight/add-listener-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceLight/create-event.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceLight/create-event-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceLight/multiple-event-listeners.html View 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceLight/multiple-event-listeners-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceLight/page-visibility.html View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceLight/page-visibility-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceLight/window-property.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceLight/window-property-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
tkent
3 years, 10 months ago (2017-02-02 06:05:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672663002/1
3 years, 10 months ago (2017-02-02 06:05:34 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 06:13:16 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/26df0a66691fd1d8d451a1dc701a...

Powered by Google App Engine
This is Rietveld 408576698