Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 2672643004: Move ClipRect and related classes from layout/ to paint/. (Closed)

Created:
3 years, 10 months ago by chrishtr
Modified:
3 years, 10 months ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ClipRect and related classes from layout/ to paint/. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2672643004 Cr-Commit-Position: refs/heads/master@{#448009} Committed: https://chromium.googlesource.com/chromium/src/+/619ee453d2ba880f8625ff7a99476ccf5f6e4211

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -211 lines) Patch
M third_party/WebKit/Source/core/layout/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ClipRect.h View 1 chunk +0 lines, -96 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ClipRect.cpp View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ClipRectsCache.h View 1 chunk +0 lines, -69 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/paint/ClipRect.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/paint/ClipRect.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/paint/ClipRects.h View 1 1 chunk +101 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/paint/ClipRectsCache.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/LayerClipRecorder.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerFragment.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (15 generated)
chrishtr
3 years, 10 months ago (2017-02-03 00:57:48 UTC) #5
Stephen Chennney
LGTM. I considered asking to put them in platform instead, but I don't think there ...
3 years, 10 months ago (2017-02-03 14:20:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672643004/40001
3 years, 10 months ago (2017-02-03 16:05:27 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 16:48:08 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/619ee453d2ba880f8625ff7a9947...

Powered by Google App Engine
This is Rietveld 408576698