Rewrite message regarding failure to store DM token

Rewrite message regarding failure to store DM token

BUG=666281
Review-Url: https://codereview.chromium.org/2672633005
Cr-Commit-Position: refs/heads/master@{#449590}
Committed: https://chromium.googlesource.com/chromium/src/+/413a99ab0e025df2ca556a90168ee1174fcc76a6

[Roman Sorokin (ftl), 2017-02-03 15:23:38]

rsorokin@chromium.org changed reviewers:
+ alemate@chromium.org, tnagel@chromium.org

[Roman Sorokin (ftl), 2017-02-03 15:23:38]

Hey Thiemo, Alex, PTAL. Thanks!

[Thiemo Nagel, 2017-02-06 10:01:42]

https://codereview.chromium.org/2672633005/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2672633005/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6230: <message
name="IDS_ENTERPRISE_ENROLLMENT_ERROR_SAVE_DEVICE_CONF" desc="Error message
shown on the enrollment screen when the system failed to some part of the device
configuration. E.g. token from the Device Management server.">
Nit: missing verb: failed to SAVE

https://codereview.chromium.org/2672633005/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
(right):

https://codereview.chromium.org/2672633005/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc:365:
ShowError(IDS_ENTERPRISE_ENROLLMENT_ERROR_SAVE_DEVICE_CONF, false);
Nit: No abbreviations plz.

[Roman Sorokin (ftl), 2017-02-06 10:44:42]

Thanks for the review! PTAL.

https://codereview.chromium.org/2672633005/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2672633005/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6230: <message
name="IDS_ENTERPRISE_ENROLLMENT_ERROR_SAVE_DEVICE_CONF" desc="Error message
shown on the enrollment screen when the system failed to some part of the device
configuration. E.g. token from the Device Management server.">
On 2017/02/06 10:01:41, Thiemo Nagel (slow) wrote:
> Nit: missing verb: failed to SAVE

Done.

https://codereview.chromium.org/2672633005/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
(right):

https://codereview.chromium.org/2672633005/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc:365:
ShowError(IDS_ENTERPRISE_ENROLLMENT_ERROR_SAVE_DEVICE_CONF, false);
On 2017/02/06 10:01:41, Thiemo Nagel (slow) wrote:
> Nit: No abbreviations plz.

Done.

[Thiemo Nagel, 2017-02-06 10:51:43]

lgtm (but I'm not an owner)

[Alexander Alekseev, 2017-02-10 02:35:31]

lgtm

[Roman Sorokin (ftl), 2017-02-10 10:45:17]

The CQ bit was checked by rsorokin@chromium.org

[commit-bot: I haz the power, 2017-02-10 10:45:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 11:34:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486723517681870,
"parent_rev": "037ca4bef92ddae569a757a66006d60cfcc7bdc5", "commit_rev":
"413a99ab0e025df2ca556a90168ee1174fcc76a6"}

[commit-bot: I haz the power, 2017-02-10 11:34:56]

Description was changed from

==========
Rewrite message regarding failure to store DM token

BUG=666281
==========

to

==========
Rewrite message regarding failure to store DM token

BUG=666281

Review-Url: https://codereview.chromium.org/2672633005
Cr-Commit-Position: refs/heads/master@{#449590}
Committed:
https://chromium.googlesource.com/chromium/src/+/413a99ab0e025df2ca556a90168e...
==========

[commit-bot: I haz the power, 2017-02-10 11:34:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/413a99ab0e025df2ca556a90168e...