Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2672633005: Rewrite message regarding failure to store DM token (Closed)

Created:
3 years, 10 months ago by Roman Sorokin (ftl)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite message regarding failure to store DM token BUG=666281 Review-Url: https://codereview.chromium.org/2672633005 Cr-Commit-Position: refs/heads/master@{#449590} Committed: https://chromium.googlesource.com/chromium/src/+/413a99ab0e025df2ca556a90168ee1174fcc76a6

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Roman Sorokin (ftl)
Hey Thiemo, Alex, PTAL. Thanks!
3 years, 10 months ago (2017-02-03 15:23:38 UTC) #2
Thiemo Nagel
https://codereview.chromium.org/2672633005/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2672633005/diff/1/chrome/app/chromeos_strings.grdp#newcode6230 chrome/app/chromeos_strings.grdp:6230: <message name="IDS_ENTERPRISE_ENROLLMENT_ERROR_SAVE_DEVICE_CONF" desc="Error message shown on the enrollment screen ...
3 years, 10 months ago (2017-02-06 10:01:42 UTC) #3
Roman Sorokin (ftl)
Thanks for the review! PTAL. https://codereview.chromium.org/2672633005/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2672633005/diff/1/chrome/app/chromeos_strings.grdp#newcode6230 chrome/app/chromeos_strings.grdp:6230: <message name="IDS_ENTERPRISE_ENROLLMENT_ERROR_SAVE_DEVICE_CONF" desc="Error message ...
3 years, 10 months ago (2017-02-06 10:44:42 UTC) #4
Thiemo Nagel
lgtm (but I'm not an owner)
3 years, 10 months ago (2017-02-06 10:51:43 UTC) #5
Alexander Alekseev
lgtm
3 years, 10 months ago (2017-02-10 02:35:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672633005/20001
3 years, 10 months ago (2017-02-10 10:45:40 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 11:34:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/413a99ab0e025df2ca556a90168e...

Powered by Google App Engine
This is Rietveld 408576698