components/autofill/core/browser/autofill_client.h - Issue 2672623005: Record Autofill form events specially for nonsecure pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_client.h

Issue 2672623005: Record Autofill form events specially for nonsecure pages (Closed)

Patch Set: fix test added in rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/autofill_client.h

diff --git a/components/autofill/core/browser/autofill_client.h b/components/autofill/core/browser/autofill_client.h

index 041d62b3a869f06a38021dd5c8398373576fc344..3960f44fdbb46f27f86e410fc7309cd65b55049a 100644

--- a/components/autofill/core/browser/autofill_client.h

+++ b/components/autofill/core/browser/autofill_client.h

@@ -17,7 +17,6 @@

#include "ui/base/window_open_disposition.h"

#include "url/gurl.h"

-class GURL;

class IdentityProvider;

class PrefService;

@@ -181,7 +180,7 @@ class AutofillClient {

virtual void OnFirstUserGestureObserved() = 0;

// If the context is secure.

- virtual bool IsContextSecure(const GURL& form_origin) = 0;

+ virtual bool IsContextSecure() = 0;

// Whether it is appropriate to show a signin promo for this user.

virtual bool ShouldShowSigninPromo() = 0;