components/autofill/core/browser/autofill_assistant.cc - Issue 2672623005: Record Autofill form events specially for nonsecure pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_assistant.cc

Issue 2672623005: Record Autofill form events specially for nonsecure pages (Closed)

Patch Set: fix test added in rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/autofill_assistant.cc

diff --git a/components/autofill/core/browser/autofill_assistant.cc b/components/autofill/core/browser/autofill_assistant.cc

index 4fccc2a7997e1d83349ee128191342f1a16befb6..3e463b614bc230862dffc84f1f3ac717eb43b1d4 100644

--- a/components/autofill/core/browser/autofill_assistant.cc

+++ b/components/autofill/core/browser/autofill_assistant.cc

@@ -31,8 +31,7 @@ bool AutofillAssistant::CanShowCreditCardAssist(

!IsAutofillCreditCardAssistEnabled() ||

// Context of the page is not secure or target URL is valid but not

// secure.

- !(autofill_manager_->client()->IsContextSecure(

- form_structures.front()->source_url()) &&

+ !(autofill_manager_->client()->IsContextSecure() &&

(!form_structures.front()->target_url().is_valid() ||

!form_structures.front()->target_url().SchemeIs("http")))) {

return false;