Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2672573002: Add vim support for highlighting GN target names (Closed)

Created:
3 years, 10 months ago by Nate Fischer
Modified:
3 years, 10 months ago
Reviewers:
scottmg
CC:
agrieve+watch_chromium.org, chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add vim support for highlighting GN target names For GN files, let the target name stand out from the directory path to the BUILD file. For example, a dependency that looks like "//base/foo:bar" will color ':bar' distinctly from the rest of the string (using the 'Special' highlighting group). BUG= Review-Url: https://codereview.chromium.org/2672573002 Cr-Commit-Position: refs/heads/master@{#447670} Committed: https://chromium.googlesource.com/chromium/src/+/809b8f0ca34beae53da551347d4281cb2da386c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/gn/misc/vim/syntax/gn.vim View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Nate Fischer
PTAL
3 years, 10 months ago (2017-02-01 23:31:13 UTC) #2
scottmg
lgtm
3 years, 10 months ago (2017-02-02 01:03:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672573002/1
3 years, 10 months ago (2017-02-02 01:05:22 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 01:21:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/809b8f0ca34beae53da551347d42...

Powered by Google App Engine
This is Rietveld 408576698