Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2672513002: [Android] Scroll to the TLD in the omnibox for http sites. (Closed)

Created:
3 years, 10 months ago by Ted C
Modified:
3 years, 10 months ago
Reviewers:
Maria
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Scroll to the TLD in the omnibox for http sites. This previously worked for https sites, but now it expands for all domains. BUG=181623 Review-Url: https://codereview.chromium.org/2672513002 Cr-Commit-Position: refs/heads/master@{#447622} Committed: https://chromium.googlesource.com/chromium/src/+/926bfbada832ec9bfdb0a007333317d3f6218a7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java View 1 chunk +10 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ted C
PTAL
3 years, 10 months ago (2017-02-01 18:52:53 UTC) #2
Maria
lgtm
3 years, 10 months ago (2017-02-01 19:29:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672513002/1
3 years, 10 months ago (2017-02-01 21:12:11 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 23:01:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/926bfbada832ec9bfdb0a0073333...

Powered by Google App Engine
This is Rietveld 408576698