Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

Issue 2672483002: [DevTools] Remove other breakpoints (Closed)
Patch Set: Code optimization Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js
index 1ec97df65295e6ebbb3fcd17fe80864626cb90d1..0248dcf4b76b884261b135d5914902e275755a09 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js
@@ -177,6 +177,7 @@ Sources.JavaScriptBreakpointsSidebarPane = class extends UI.ThrottledWidget {
return;
var breakpoints = this._breakpointManager.findBreakpoints(uiLocation.uiSourceCode, uiLocation.lineNumber);
+ var allBreakpoints = this._breakpointManager.allBreakpoints();
var contextMenu = new UI.ContextMenu(event);
var removeEntryTitle = breakpoints.length > 1 ? Common.UIString('Remove all breakpoints in line') :
@@ -191,19 +192,24 @@ Sources.JavaScriptBreakpointsSidebarPane = class extends UI.ThrottledWidget {
breakpointActiveTitle,
this._breakpointManager.setBreakpointsActive.bind(this._breakpointManager, !breakpointActive));
- contextMenu.appendSeparator();
- if (breakpoints.some(breakpoint => !breakpoint.enabled())) {
- var enableTitle = Common.UIString('Enable all breakpoints');
- contextMenu.appendItem(
- enableTitle, this._breakpointManager.toggleAllBreakpoints.bind(this._breakpointManager, true));
- }
- if (breakpoints.some(breakpoint => breakpoint.enabled())) {
- var disableTitle = Common.UIString('Disable all breakpoints');
+ if (allBreakpoints.length > 1) {
pfeldman 2017/02/01 19:41:02 It was nice to have these items present unconditio
+ contextMenu.appendSeparator();
+ if (breakpoints.some(breakpoint => !breakpoint.enabled())) {
+ var enableTitle = Common.UIString('Enable all breakpoints');
+ contextMenu.appendItem(
+ enableTitle, this._breakpointManager.toggleAllBreakpoints.bind(null, allBreakpoints, true));
+ }
+ if (breakpoints.some(breakpoint => breakpoint.enabled())) {
+ var disableTitle = Common.UIString('Disable all breakpoints');
+ contextMenu.appendItem(
+ disableTitle, this._breakpointManager.toggleAllBreakpoints.bind(null, allBreakpoints, false));
+ }
+ var removeAllTitle = Common.UIString('Remove all breakpoints');
+ contextMenu.appendItem(removeAllTitle, this._breakpointManager.removeAllBreakpoints.bind(null, allBreakpoints));
+ var removeOtherTitle = Common.UIString('Remove other breakpoints');
contextMenu.appendItem(
- disableTitle, this._breakpointManager.toggleAllBreakpoints.bind(this._breakpointManager, false));
+ removeOtherTitle, this._breakpointManager.removeOtherBreakpoints.bind(null, allBreakpoints, breakpoints));
}
- var removeAllTitle = Common.UIString('Remove all breakpoints');
- contextMenu.appendItem(removeAllTitle, this._breakpointManager.removeAllBreakpoints.bind(this._breakpointManager));
contextMenu.show();
}

Powered by Google App Engine
This is Rietveld 408576698