[DevTools] Remove other breakpoints

third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

Index: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js b/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
index a1fbf217bb89891b6220d021ed4cce76035fb2be..e07b41ffe009573fa8ef3bf208353a4aa87eb420 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
@@ -56,7 +56,8 @@ Bindings.BreakpointManager = class extends Common.Object {
     this._workspace.addEventListener(Workspace.Workspace.Events.ProjectRemoved, this._projectRemoved, this);
     this._workspace.addEventListener(Workspace.Workspace.Events.UISourceCodeAdded, this._uiSourceCodeAdded, this);
     this._workspace.addEventListener(Workspace.Workspace.Events.UISourceCodeRemoved, this._uiSourceCodeRemoved, this);
-    this._debuggerWorkspaceBinding.addEventListener(Bindings.DebuggerWorkspaceBinding.Events.SourceMappingChanged, this._uiSourceCodeMappingChanged, this);
+    this._debuggerWorkspaceBinding.addEventListener(
+        Bindings.DebuggerWorkspaceBinding.Events.SourceMappingChanged, this._uiSourceCodeMappingChanged, this);
 
     targetManager.observeTargets(this, SDK.Target.Capability.JS);
   }
@@ -325,7 +326,7 @@ Bindings.BreakpointManager = class extends Common.Object {
   /**
    * @return {!Array.<!Bindings.BreakpointManager.Breakpoint>}
    */
-  _allBreakpoints() {
+  allBreakpoints() {
     var result = [];
     var uiSourceCodes = this._breakpointsForUISourceCode.keysArray();
     for (var i = 0; i < uiSourceCodes.length; ++i)
@@ -370,20 +371,36 @@ Bindings.BreakpointManager = class extends Common.Object {
   }
 
   /**
+   * @param {!Array.<!Bindings.BreakpointManager.Breakpoint>} breakpoints
    * @param {boolean} toggleState
    */
-  toggleAllBreakpoints(toggleState) {
-    var breakpoints = this._allBreakpoints();
+  toggleAllBreakpoints(breakpoints, toggleState) {

[pfeldman, 2017/02/01 19:41:02]

I would leave this as is.

     for (var i = 0; i < breakpoints.length; ++i)
       breakpoints[i].setEnabled(toggleState);
   }
 
-  removeAllBreakpoints() {
-    var breakpoints = this._allBreakpoints();
+  /**
+   * @param {!Array.<!Bindings.BreakpointManager.Breakpoint>} breakpoints
+   */
+  removeAllBreakpoints(breakpoints) {

[pfeldman, 2017/02/01 19:41:02]

I would leave this as is.

     for (var i = 0; i < breakpoints.length; ++i)
       breakpoints[i].remove();
   }
 
+  /**
+   * @param {!Array.<!Bindings.BreakpointManager.Breakpoint>} allBreakpoints
+   * @param {!Array.<!Bindings.BreakpointManager.Breakpoint>} selectedBreakpoints
+   */
+  removeOtherBreakpoints(allBreakpoints, selectedBreakpoints) {

[pfeldman, 2017/02/01 19:41:02]

Here you can make it accept the one (ones) you want to preserve. Pass a Set
instead of array for the faster lookup.

[Oleksii Kadurin, 2017/02/01 20:16:37]

And compare breakpoints not by _breakpointStorageId(), but by their links,
right?
Like this:
    allBreakpoints.forEach(breakpoint => {
      if (!selectedBreakpoints.has(breakpoint))      
        breakpoint.remove();
    });

+    allBreakpoints.forEach(breakpoint => {
+      var storageId = breakpoint._breakpointStorageId();
+      var isSelected =
+          selectedBreakpoints.some(selectedBreakpoint => selectedBreakpoint._breakpointStorageId() === storageId);
+      if (!isSelected)
+        breakpoint.remove();
+    });
+  }
+
   _projectRemoved(event) {
     var project = /** @type {!Workspace.Project} */ (event.data);
     var uiSourceCodes = project.uiSourceCodes();