Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2672463003: Remove dead code since PDFWebContentsHelper::ShowOpenInReaderPrompt isn't called anymore. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
dsinclair
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead code since PDFWebContentsHelper::ShowOpenInReaderPrompt isn't called anymore. BUG=682002 Review-Url: https://codereview.chromium.org/2672463003 Cr-Commit-Position: refs/heads/master@{#447651} Committed: https://chromium.googlesource.com/chromium/src/+/f25b3265878e57ef40f5422716f3b4f6e840a846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -455 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +0 lines, -51 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/location_bar/location_bar.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 8 chunks +1 line, -23 lines 0 comments Download
D chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc View 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/browser/ui/views/open_pdf_in_reader_bubble_view.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/ui/views/open_pdf_in_reader_bubble_view.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/pdf/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D components/pdf/browser/open_pdf_in_reader_prompt_client.h View 1 chunk +0 lines, -36 lines 0 comments Download
M components/pdf/browser/pdf_web_contents_helper.h View 3 chunks +0 lines, -17 lines 0 comments Download
M components/pdf/browser/pdf_web_contents_helper.cc View 3 chunks +0 lines, -22 lines 0 comments Download
M components/pdf/browser/pdf_web_contents_helper_client.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jam
3 years, 10 months ago (2017-02-01 19:29:45 UTC) #6
dsinclair
lgtm
3 years, 10 months ago (2017-02-01 23:57:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672463003/1
3 years, 10 months ago (2017-02-02 00:05:34 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 00:12:02 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f25b3265878e57ef40f5422716f3...

Powered by Google App Engine
This is Rietveld 408576698