Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2672433002: Fix layout of the sync and sign-in error dialogs when the page zoom is increased. (Closed)

Created:
3 years, 10 months ago by msarda
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix layout of the sync and sign-in error dialogs when the page zoom is increased. This CL does the following changes to the sync and sign-in error dialogs: * Disables the web page zoom as these dialogs should look as native dialogs. * Uses the document.body.offsetHeight instead of the scrollheight when computing the preferred size for the dialog's webview as the scrollHeight is different depending on the page zoom size (the values of the scrollHeight are equal to offsetHeight / Chrome's page_zoom) * Display the scrollbars as sometimes the dialog view may be smaller than the preffered height of the scrollview. BUG=685021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2658783004 Cr-Commit-Position: refs/heads/master@{#446848} (cherry picked from commit 55529d0408f80b154fd394f4f8e1749f5d17329a) Review-Url: https://codereview.chromium.org/2672433002 . Cr-Commit-Position: refs/branch-heads/2924@{#896} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/435efe2a501c668b9cc2515c2a04581a2a918cfb

Patch Set 1 #

Patch Set 2 : Fix layout of the sync and sign-in error dialogs when the page zoom is increased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M chrome/browser/resources/signin/signin_error/signin_error.js View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/resources/signin/signin_shared_css.html View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/resources/signin/sync_confirmation/sync_confirmation.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
msarda
3 years, 10 months ago (2017-02-01 10:32:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
435efe2a501c668b9cc2515c2a04581a2a918cfb.

Powered by Google App Engine
This is Rietveld 408576698