Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2672363002: Link type feedback vectors to the shared function info. (Closed)

Created:
3 years, 10 months ago by Yang
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, rmcilroy, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Link type feedback vectors to the shared function info. Previously, both type feedback vector and the shared function info of a function points to the matching type feedback metadata. This makes finding the shared function info of a type feedback vector difficult. Instead, we now point the type feeback vector to the shared function info, and find the metadata through the shared function info. Also remove the obsolete empty type feedback vector. R=hpayer@chromium.org, mvstanton@chromium.org BUG=v8:5808 Review-Url: https://codereview.chromium.org/2672363002 Cr-Commit-Position: refs/heads/master@{#43026} Committed: https://chromium.googlesource.com/v8/v8/+/c78d7fa1aefb4544ace6b248fe6ac247bf5cbed3

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -69 lines) Patch
M src/code-stub-assembler.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/debug/liveedit.cc View 1 2 chunks +8 lines, -7 lines 0 comments Download
M src/feedback-vector.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M src/feedback-vector.cc View 1 3 chunks +4 lines, -9 lines 0 comments Download
M src/feedback-vector-inl.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/heap/heap.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/heap/heap.cc View 1 2 chunks +0 lines, -18 lines 0 comments Download
M src/heap/object-stats.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/objects.cc View 1 3 chunks +2 lines, -7 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +1 line, -6 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/interpreter-tester.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-feedback-vector.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Yang
3 years, 10 months ago (2017-02-06 14:16:18 UTC) #1
mvstanton
LGTM. There is some overlap with Igor's in-flight CL (https://codereview.chromium.org/2673383002/), he also gets rid of ...
3 years, 10 months ago (2017-02-07 09:19:40 UTC) #2
Hannes Payer (out of office)
lgtm
3 years, 10 months ago (2017-02-07 11:49:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672363002/20001
3 years, 10 months ago (2017-02-08 08:05:37 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 08:33:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c78d7fa1aefb4544ace6b248fe6ac247bf5...

Powered by Google App Engine
This is Rietveld 408576698