Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2672273002: Add missing documentation for Allocator.h macros + EAGERLY_FINALIZE(). (Closed)

Created:
3 years, 10 months ago by sof
Modified:
3 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing documentation for Allocator.h macros + EAGERLY_FINALIZE(). R=haraken BUG=662326 Review-Url: https://codereview.chromium.org/2672273002 Cr-Commit-Position: refs/heads/master@{#448234} Committed: https://chromium.googlesource.com/chromium/src/+/218c408dbc4f309adc8f03a845c214bdc70a33c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md View 1 chunk +31 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
sof
please take a look.
3 years, 10 months ago (2017-02-06 10:29:01 UTC) #2
haraken
LGTM
3 years, 10 months ago (2017-02-06 10:52:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672273002/1
3 years, 10 months ago (2017-02-06 10:54:12 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 12:03:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/218c408dbc4f309adc8f03a845c2...

Powered by Google App Engine
This is Rietveld 408576698