Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2672203002: Ensure we align zone memory at 8 byte boundaries on all platforms (Closed)

Created:
3 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 10 months ago
Reviewers:
Toon Verwaest, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ensure we align zone memory at 8 byte boundaries on all platforms BUG=v8:5668 R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2672203002 Cr-Commit-Position: refs/heads/master@{#42959} Committed: https://chromium.googlesource.com/v8/v8/+/b049d1a5986202c2ecf05de00a31ab2be820fc06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -23 lines) Patch
M src/zone/zone.h View 1 chunk +2 lines, -10 lines 0 comments Download
M src/zone/zone.cc View 5 chunks +5 lines, -13 lines 0 comments Download
M test/unittests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/unittests/zone/zone-unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jochen (gone - plz use gerrit)
3 years, 10 months ago (2017-02-05 03:51:43 UTC) #1
jochen (gone - plz use gerrit)
ptal
3 years, 10 months ago (2017-02-06 09:14:25 UTC) #7
Yang
On 2017/02/06 09:14:25, jochen wrote: > ptal lgtm.
3 years, 10 months ago (2017-02-06 10:21:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672203002/1
3 years, 10 months ago (2017-02-06 10:41:01 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 11:15:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b049d1a5986202c2ecf05de00a31ab2be82...

Powered by Google App Engine
This is Rietveld 408576698