Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2672093002: Convert PeriodicWave Audit tests to testharness (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert PeriodicWave Audit tests to testharness Converted tests using the script for f in `grep -l Audit *.html` do # Replace js-test with testharness and add testharnessreport.js sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\ \1\2testharnessreport.js\3 ;' $f # Remove old js-test methods that no longer exist. sed -i '/^[ ]*\(description(.*)\|finishJSTest()\);[ ]*$/d' $f # Remove jsTestIsAsync stuff sed -i '/^[ ]*window.jsTestIsAsync *= *true;[ ]*$/d' $f # Remove expected results file. base=`basename $f .html` git rm $base-expected.txt done Had to adjust periodicwave-lengths.html manually for uses of testPassed/testFailed. BUG=688491 TEST=periodicwave-lengths.html, periodicwave-normalization.html Review-Url: https://codereview.chromium.org/2672093002 Cr-Commit-Position: refs/heads/master@{#450425} Committed: https://chromium.googlesource.com/chromium/src/+/eced9c086e9b8bfa1aaa00102b8578fb7e187f40

Patch Set 1 #

Patch Set 2 : Clean up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -75 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-lengths.html View 1 4 chunks +6 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-lengths-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-normalization.html View 1 2 chunks +3 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-normalization-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-02-10 17:10:57 UTC) #2
hongchan
lgtm
3 years, 10 months ago (2017-02-14 17:55:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672093002/20001
3 years, 10 months ago (2017-02-14 17:57:43 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 18:59:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eced9c086e9b8bfa1aaa00102b85...

Powered by Google App Engine
This is Rietveld 408576698