Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2672053003: Pass is_module flag when we V8ScriptRunner::compileModule (Closed)

Created:
3 years, 10 months ago by kouhei (in TOK)
Modified:
3 years, 10 months ago
Reviewers:
haraken, adamk
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass is_module flag when we V8ScriptRunner::compileModule BUG=594639 Review-Url: https://codereview.chromium.org/2672053003 Cr-Commit-Position: refs/heads/master@{#448206} Committed: https://chromium.googlesource.com/chromium/src/+/1aae17db472fc55ba8f985957fe0171d41fe5899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
kouhei (in TOK)
PTAL
3 years, 10 months ago (2017-02-03 21:53:07 UTC) #2
haraken
LGTM
3 years, 10 months ago (2017-02-04 09:34:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672053003/1
3 years, 10 months ago (2017-02-04 13:02:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-04 15:03:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672053003/1
3 years, 10 months ago (2017-02-06 02:08:26 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 03:28:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1aae17db472fc55ba8f985957fe0...

Powered by Google App Engine
This is Rietveld 408576698