Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2672053002: Convert Oscillator Audit tests to testharness (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Oscillator Audit tests to testharness These tests were converted using the script for f in `grep -l Audit *.html` do # Replace js-test with testharness and add testharnessreport.js sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\ \1\2testharnessreport.js\3 ;' $f # Remove old js-test methods that no longer exist. sed -i '/^[ ]*\(description(.*)\|finishJSTest()\);[ ]*$/d' $f # Remove jsTestIsAsync stuff sed -i '/^[ ]*window.jsTestIsAsync *= *true;[ ]*$/d' $f # Remove expected results file. base=`basename $f .html` git rm $base-expected.txt done late-start-testing.js need to be converted manually. BUG=688414 TEST=osc-low-freq.html, osc-negative-freq.html, oscillator-late-start.html Review-Url: https://codereview.chromium.org/2672053002 Cr-Commit-Position: refs/heads/master@{#451365} Committed: https://chromium.googlesource.com/chromium/src/+/284e8e691ecc8f14c3e3e860dde7adf7081982e8

Patch Set 1 #

Patch Set 2 : Remove old code. #

Patch Set 3 : Minor cleanups #

Total comments: 3

Patch Set 4 : Rebase #

Total comments: 2

Patch Set 5 : Address review comments #

Messages

Total messages: 14 (5 generated)
Raymond Toy
PTAL. Note that osc-low-freq.html doesn't actually use Audit (new or old) at all. Should I ...
3 years, 10 months ago (2017-02-08 16:05:54 UTC) #1
Raymond Toy
3 years, 10 months ago (2017-02-09 22:14:56 UTC) #3
Raymond Toy
PTAL
3 years, 10 months ago (2017-02-10 17:11:30 UTC) #4
hongchan
https://codereview.chromium.org/2672053002/diff/40001/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html File third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html (right): https://codereview.chromium.org/2672053002/diff/40001/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html#newcode1 third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html:1: <!DOCTYPE html> New changes were landed recently. This needs ...
3 years, 10 months ago (2017-02-14 17:58:41 UTC) #5
Raymond Toy
https://codereview.chromium.org/2672053002/diff/40001/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html File third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html (right): https://codereview.chromium.org/2672053002/diff/40001/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html#newcode1 third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html:1: <!DOCTYPE html> On 2017/02/14 17:58:41, hongchan wrote: > New ...
3 years, 10 months ago (2017-02-14 20:06:08 UTC) #6
hongchan
lgtm wit nit https://codereview.chromium.org/2672053002/diff/60001/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html File third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html (right): https://codereview.chromium.org/2672053002/diff/60001/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html#newcode27 third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html:27: successfullyParsed = true; This needs to ...
3 years, 10 months ago (2017-02-17 18:23:16 UTC) #7
Raymond Toy
https://codereview.chromium.org/2672053002/diff/60001/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html File third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html (right): https://codereview.chromium.org/2672053002/diff/60001/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html#newcode27 third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html:27: successfullyParsed = true; On 2017/02/17 18:23:16, hongchan wrote: > ...
3 years, 10 months ago (2017-02-17 18:55:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672053002/80001
3 years, 10 months ago (2017-02-17 18:55:39 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 20:07:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/284e8e691ecc8f14c3e3e860dde7...

Powered by Google App Engine
This is Rietveld 408576698