Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2671993003:
Document iOS "Session.*" histograms. (Closed)
DescriptionDocument iOS "Session.*" histograms.
The histograms "Session.ClosedTabCounts", "Session.NewTabCounts" and
"Session.OpenedTabCounts" have never been documented and cannot be
easily be checked on uma. Document them to fix this.
BUG=None
Review-Url: https://codereview.chromium.org/2671993003
Cr-Commit-Position: refs/heads/master@{#448010}
Committed: https://chromium.googlesource.com/chromium/src/+/8d1c2de0c0510b1d941a12d9ae2b729d03f40bd6
Patch Set 1 #
Total comments: 1
Patch Set 2 : Update description. #Messages
Total messages: 17 (8 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Description was changed from ========== Document iOS "Session.*" histograms. The histograms "Session.ClosedTabCounts", "Session.NewTabCounts" and "Session.OpenedTabCounts" have never been documented and cannot be easily be checked on uma. Document them to fix this. BUG=None ========== to ========== Document iOS "Session.*" histograms. The histograms "Session.ClosedTabCounts", "Session.NewTabCounts" and "Session.OpenedTabCounts" have never been documented and cannot be easily be checked on uma. Document them to fix this. BUG=None ==========
sdefresne@chromium.org changed reviewers: + asvitkine@chromium.org, rohitrao@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Can you both take a look?
lgtm % comments https://codereview.chromium.org/2671993003/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2671993003/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:61378: + <summary>The number of tabs closed by the user.</summary> Mention these are iOS-specific. Also, mention when this is recorded. On app background/quit?
On 2017/02/03 15:19:58, Alexei Svitkine (very slow) wrote: > lgtm % comments > > https://codereview.chromium.org/2671993003/diff/1/tools/metrics/histograms/hi... > File tools/metrics/histograms/histograms.xml (right): > > https://codereview.chromium.org/2671993003/diff/1/tools/metrics/histograms/hi... > tools/metrics/histograms/histograms.xml:61378: + <summary>The number of tabs > closed by the user.</summary> > Mention these are iOS-specific. > > Also, mention when this is recorded. On app background/quit? Is there a recommended format for specifying the histogram is iOS specific?
On 2017/02/03 15:22:00, sdefresne wrote: > On 2017/02/03 15:19:58, Alexei Svitkine (very slow) wrote: > > lgtm % comments > > > > > https://codereview.chromium.org/2671993003/diff/1/tools/metrics/histograms/hi... > > File tools/metrics/histograms/histograms.xml (right): > > > > > https://codereview.chromium.org/2671993003/diff/1/tools/metrics/histograms/hi... > > tools/metrics/histograms/histograms.xml:61378: + <summary>The number of tabs > > closed by the user.</summary> > > Mention these are iOS-specific. > > > > Also, mention when this is recorded. On app background/quit? > > Is there a recommended format for specifying the histogram is iOS specific? Nothing formal. Just a sentence like "This histogram is only logged on iOS."
LGTM As Alexei said, defining what a "session" is would be helpful. From the code, it looks like we record this whenever the app is backgrounded or quit.
I've updated the description, is this better?
lgtm
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rohitrao@chromium.org Link to the patchset: https://codereview.chromium.org/2671993003/#ps20001 (title: "Update description.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486136863568140,
"parent_rev": "619ee453d2ba880f8625ff7a99476ccf5f6e4211", "commit_rev":
"8d1c2de0c0510b1d941a12d9ae2b729d03f40bd6"}
Message was sent while issue was closed.
Description was changed from ========== Document iOS "Session.*" histograms. The histograms "Session.ClosedTabCounts", "Session.NewTabCounts" and "Session.OpenedTabCounts" have never been documented and cannot be easily be checked on uma. Document them to fix this. BUG=None ========== to ========== Document iOS "Session.*" histograms. The histograms "Session.ClosedTabCounts", "Session.NewTabCounts" and "Session.OpenedTabCounts" have never been documented and cannot be easily be checked on uma. Document them to fix this. BUG=None Review-Url: https://codereview.chromium.org/2671993003 Cr-Commit-Position: refs/heads/master@{#448010} Committed: https://chromium.googlesource.com/chromium/src/+/8d1c2de0c0510b1d941a12d9ae2b... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8d1c2de0c0510b1d941a12d9ae2b... |
