Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2671933003: Move Geolocation out from fast/dom. (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
CC:
blink-reviews, chromium-reviews, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Geolocation out from fast/dom. Geolocation API isn't a part of DOM. This CL has no behavior changes. BUG=685886 R=mvanouwerkerk@chromium.org Review-Url: https://codereview.chromium.org/2671933003 Cr-Commit-Position: refs/heads/master@{#448422} Committed: https://chromium.googlesource.com/chromium/src/+/c5e88f0990ad395ae9c078903099ac02af08ea01

Patch Set 1 : . #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -3285 lines) Patch
M WATCHLISTS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/ASANExpectations View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/argument-types.html View 1 chunk +0 lines, -128 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/argument-types-expected.txt View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/cached-position-called-once.html View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/cached-position-called-once-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/callback-exception.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/callback-exception-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/callback-to-deleted-context.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/callback-to-deleted-context-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/callback-to-remote-context.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/callback-to-remote-context-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/callback-to-remote-context2.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/callback-to-remote-context2-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/clear-watch-invalid-id-crash.html View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/clear-watch-invalid-id-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/coordinates-interface-attributes.html View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/coordinates-interface-attributes-expected.txt View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/delayed-permission-allowed.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/delayed-permission-allowed-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/delayed-permission-allowed-for-multiple-requests.html View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/delayed-permission-allowed-for-multiple-requests-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/delayed-permission-denied.html View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/delayed-permission-denied-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/delayed-permission-denied-for-multiple-requests.html View 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/delayed-permission-denied-for-multiple-requests-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/disconnected-frame.html View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/disconnected-frame-already.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/disconnected-frame-already-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/disconnected-frame-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/disconnected-frame-permission-denied.html View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/disconnected-frame-permission-denied-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/enabled.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/enabled-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/error.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/error-clear-watch.html View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/error-clear-watch-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/error-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/error-service-connection-error.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/error-service-connection-error-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/maximum-age.html View 1 chunk +0 lines, -129 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/maximum-age-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/multiple-requests.html View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/multiple-requests-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/not-enough-arguments.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/not-enough-arguments-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/notimer-after-unload.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/notimer-after-unload-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-denied.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-denied-already-clear-watch.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-denied-already-clear-watch-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-denied-already-error.html View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-denied-already-error-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-denied-already-success.html View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-denied-already-success-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-denied-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-denied-stops-watches.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-denied-stops-watches-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-service-connection-error.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-service-connection-error-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/position-string.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/position-string-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/reentrant-error.html View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/reentrant-error-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/reentrant-permission-denied.html View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/reentrant-permission-denied-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/reentrant-success.html View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/reentrant-success-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/remove-remote-context-in-error-callback-crash.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/remove-remote-context-in-error-callback-crash-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/cached-position-iframe-inner.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/callback-to-deleted-context-inner1.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/callback-to-deleted-context-inner2.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/callback-to-remote-context-inner.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/disconnected-frame-already-inner1.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/disconnected-frame-already-inner2.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/disconnected-frame-inner.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/geolocation-mock.js View 1 chunk +0 lines, -186 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/remove-remote-context-in-error-callback-crash-inner.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/window-close-popup.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/success.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/success-clear-watch.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/success-clear-watch-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/success-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/timeout.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/timeout-clear-watch.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/timeout-clear-watch-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/timeout-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/timeout-negative.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/timeout-negative-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/timeout-over-max-of-unsigned.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/timeout-over-max-of-unsigned-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/timeout-zero.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/timeout-zero-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/timestamp.html View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/timestamp-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/watch.html View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/watch-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/watchPosition-page-visibility.html View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/watchPosition-page-visibility-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/watchPosition-unique.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/watchPosition-unique-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/window-close-crash.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Geolocation/window-close-crash-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/argument-types.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/argument-types-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/cached-position-called-once.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/cached-position-called-once-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/callback-exception.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/callback-exception-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/callback-to-deleted-context.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/callback-to-deleted-context-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/callback-to-remote-context.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/callback-to-remote-context-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/callback-to-remote-context2.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/callback-to-remote-context2-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/clear-watch-invalid-id-crash.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/clear-watch-invalid-id-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/coordinates-interface-attributes.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/coordinates-interface-attributes-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-allowed.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-allowed-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-allowed-for-multiple-requests.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-allowed-for-multiple-requests-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-denied.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-denied-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-denied-for-multiple-requests.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-denied-for-multiple-requests-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/disconnected-frame.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/disconnected-frame-already.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/disconnected-frame-already-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/disconnected-frame-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/disconnected-frame-permission-denied.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/disconnected-frame-permission-denied-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/enabled.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/enabled-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/error.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/error-clear-watch.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/error-clear-watch-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/error-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/error-service-connection-error.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/error-service-connection-error-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/maximum-age.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/maximum-age-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/multiple-requests.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/multiple-requests-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/not-enough-arguments.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/not-enough-arguments-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/notimer-after-unload.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/notimer-after-unload-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/permission-denied.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/permission-denied-already-clear-watch.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/permission-denied-already-clear-watch-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/permission-denied-already-error.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/permission-denied-already-error-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/permission-denied-already-success.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/permission-denied-already-success-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/permission-denied-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/permission-denied-stops-watches.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/permission-denied-stops-watches-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/permission-service-connection-error.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/permission-service-connection-error-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/position-string.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/position-string-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/reentrant-error.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/reentrant-error-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/reentrant-permission-denied.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/reentrant-permission-denied-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/reentrant-success.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/reentrant-success-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/remove-remote-context-in-error-callback-crash.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/remove-remote-context-in-error-callback-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/resources/cached-position-iframe-inner.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/resources/callback-to-deleted-context-inner1.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/resources/callback-to-deleted-context-inner2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/resources/callback-to-remote-context-inner.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/resources/disconnected-frame-already-inner1.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/resources/disconnected-frame-already-inner2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/resources/disconnected-frame-inner.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/resources/geolocation-mock.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/resources/remove-remote-context-in-error-callback-crash-inner.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/resources/window-close-popup.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/success.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/success-clear-watch.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/success-clear-watch-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/success-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/timeout.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/timeout-clear-watch.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/timeout-clear-watch-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/timeout-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/timeout-negative.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/timeout-negative-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/timeout-over-max-of-unsigned.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/timeout-over-max-of-unsigned-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/timeout-zero.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/timeout-zero-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/timestamp.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/timestamp-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/watch.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/watch-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/watchPosition-page-visibility.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/watchPosition-page-visibility-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/watchPosition-unique.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/watchPosition-unique-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/window-close-crash.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/geolocation-api/window-close-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/resources/geolocation.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (18 generated)
Michael van Ouwerkerk
lgtm
3 years, 10 months ago (2017-02-03 14:52:29 UTC) #9
tkent
On 2017/02/03 at 14:52:29, mvanouwerkerk wrote: > lgtm Thank you for super-fast review!
3 years, 10 months ago (2017-02-04 18:04:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671933003/40001
3 years, 10 months ago (2017-02-04 18:04:45 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-04 20:05:10 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671933003/40001
3 years, 10 months ago (2017-02-06 20:58:05 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 22:48:12 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c5e88f0990ad395ae9c078903099...

Powered by Google App Engine
This is Rietveld 408576698