third_party/WebKit/Source/modules/mediasource/TrackDefaultList.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediasource/TrackDefaultList.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/mediasource/TrackDefaultList.cpp

diff --git a/third_party/WebKit/Source/modules/mediasource/TrackDefaultList.cpp b/third_party/WebKit/Source/modules/mediasource/TrackDefaultList.cpp

index dac4d2e06df0e966fcfa20445aae8dc88b47398f..8aa754a01f0397605f9f3e3d1a599c70c24057ae 100644

--- a/third_party/WebKit/Source/modules/mediasource/TrackDefaultList.cpp

+++ b/third_party/WebKit/Source/modules/mediasource/TrackDefaultList.cpp

@@ -35,7 +35,7 @@ TrackDefaultList* TrackDefaultList::create(

for (const auto& trackDefault : trackDefaults) {

TypeAndID key =

TypeAndID(trackDefault->type(), trackDefault->byteStreamTrackID());

- if (!typeAndIDToTrackDefaultMap.add(key, trackDefault).isNewEntry) {

+ if (!typeAndIDToTrackDefaultMap.insert(key, trackDefault).isNewEntry) {

exceptionState.throwDOMException(

InvalidAccessError, "Duplicate TrackDefault type (" + key.first +

") and byteStreamTrackID (" + key.second +