Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2671883002: Convert GainNode tests to testharness (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert GainNode tests to testharness Manually converted the tests to use testharness. Also modified gain.html not to create an audio file. Instead, we load up the reference output and compare against the output of the gain node. Test passes if the individual samples are close enough and the SNR is high enough. BUG=688169 TEST=gain-basic.html, gain.html Review-Url: https://codereview.chromium.org/2671883002 Cr-Commit-Position: refs/heads/master@{#448418} Committed: https://chromium.googlesource.com/chromium/src/+/48b791c315ea56c1cd29a01283e466afd3dc4f08

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -78 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/Gain/gain.html View 1 1 chunk +79 lines, -51 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Gain/gain-basic.html View 1 chunk +16 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/Gain/gain-basic-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-02-03 16:36:54 UTC) #2
hongchan
lgtm with nit https://codereview.chromium.org/2671883002/diff/1/third_party/WebKit/LayoutTests/webaudio/Gain/gain.html File third_party/WebKit/LayoutTests/webaudio/Gain/gain.html (right): https://codereview.chromium.org/2671883002/diff/1/third_party/WebKit/LayoutTests/webaudio/Gain/gain.html#newcode105 third_party/WebKit/LayoutTests/webaudio/Gain/gain.html:105: .then(task.done.bind(task)); task => task.done()
3 years, 10 months ago (2017-02-06 17:34:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671883002/20001
3 years, 10 months ago (2017-02-06 21:32:56 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 22:40:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/48b791c315ea56c1cd29a01283e4...

Powered by Google App Engine
This is Rietveld 408576698