Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2671853004: Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. (Closed)

Created:
3 years, 10 months ago by zakerinasab
Modified:
3 years, 10 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. This change replaces js-test.js assertions with testharness.js assertions. The expectation files are removed as they are not needed anymore. To simplify review and landing, each change corrects 10 tests. BUG=639732 Review-Url: https://codereview.chromium.org/2671853004 Cr-Commit-Position: refs/heads/master@{#448644} Committed: https://chromium.googlesource.com/chromium/src/+/3dae9e7b5e6ab5604b8f32916ab0a45a59eeb269

Patch Set 1 #

Patch Set 2 : Corrections #

Patch Set 3 : Corrections #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -340 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/access-zero-sized-canvas.html View 1 chunk +14 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/access-zero-sized-canvas-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/alpha.html View 1 2 2 chunks +54 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/alpha.js View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/alpha-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/arc-crash.html View 2 chunks +8 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/arc-crash-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/arc360.html View 1 chunk +13 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/arc360-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/bug503422.html View 1 chunk +7 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/bug503422-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/bug544329.html View 1 chunk +7 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/bug544329-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-2d-imageData-create-nonfinite.html View 1 chunk +16 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-2d-imageData-create-nonfinite-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-after-destroy-iframe.html View 4 chunks +15 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-after-destroy-iframe-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-after-detachment.html View 3 chunks +11 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-after-detachment-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-alphaImageData-behavior.html View 1 chunk +26 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-alphaImageData-behavior.js View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-alphaImageData-behavior-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/alpha-expected.txt View 1 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
zakerinasab
CL uploaded. PTAL.
3 years, 10 months ago (2017-02-03 16:43:58 UTC) #3
Justin Novosad
lgtm
3 years, 10 months ago (2017-02-07 16:06:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671853004/40001
3 years, 10 months ago (2017-02-07 16:33:13 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 16:46:51 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3dae9e7b5e6ab5604b8f32916ab0...

Powered by Google App Engine
This is Rietveld 408576698