Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h

Issue 267183002: Password manager: Implement password generation UI for Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove some dead code, add TODO. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h
diff --git a/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h b/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h
new file mode 100644
index 0000000000000000000000000000000000000000..5cf7ec4750d1664feded93d86be5fc2991d2f451
--- /dev/null
+++ b/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h
@@ -0,0 +1,34 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
Ilya Sherman 2014/05/09 21:51:28 nit: 2014
Patrick Dubroy 2014/05/12 14:13:39 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_COCOA_AUTOFILL_PASSWORD_GENERATION_POPUP_VIEW_COCOA_H_
+#define CHROME_BROWSER_UI_COCOA_AUTOFILL_PASSWORD_GENERATION_POPUP_VIEW_COCOA_H_
+
+#import <Cocoa/Cocoa.h>
+
+#import "ui/base/cocoa/base_view.h"
Ilya Sherman 2014/05/09 21:51:28 nit: This is probably not needed -- right?
Patrick Dubroy 2014/05/12 14:13:39 Done.
+#include "chrome/browser/ui/autofill/password_generation_popup_controller.h"
+#import "chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.h"
Ilya Sherman 2014/05/09 21:51:28 nit: Should this be base_view?
Patrick Dubroy 2014/05/12 14:13:39 Yep, fixed.
+#import "chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h"
Ilya Sherman 2014/05/09 21:51:28 Am I misreading this, or is this header attempting
Patrick Dubroy 2014/05/12 14:13:39 Yes, not sure what happened there! Fixed.
+
+namespace autofill {
+class AutofillPopupController;
+} // namespace autofill
+
+// Draws the native password generation popup view on Mac.
+@interface PasswordGenerationPopupViewCocoa : AutofillPopupBaseViewCocoa {
+ @private
+ // The cross-platform controller for this view.
+ __weak autofill::PasswordGenerationPopupController* controller_;
+}
Ilya Sherman 2014/05/09 21:51:28 nit: Please leave a blank line after this one.
Patrick Dubroy 2014/05/12 14:13:39 Done.
+// Designated initializer.
+- (id)initWithController:
+ (autofill::PasswordGenerationPopupController*)controller
+ frame:(NSRect)frame;
+
+- (void)controllerDestroyed;
+
+@end
+
+#endif // CHROME_BROWSER_UI_COCOA_AUTOFILL_PASSWORD_GENERATION_POPUP_VIEW_COCOA_H_

Powered by Google App Engine
This is Rietveld 408576698