Password manager: Implement password generation UI for Mac.

chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[Ilya Sherman, 2014/05/09 21:51:28]

nit: 2014

[Patrick Dubroy, 2014/05/12 14:13:39]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_COCOA_AUTOFILL_PASSWORD_GENERATION_POPUP_VIEW_COCOA_H_
+#define CHROME_BROWSER_UI_COCOA_AUTOFILL_PASSWORD_GENERATION_POPUP_VIEW_COCOA_H_
+
+#import <Cocoa/Cocoa.h>
+
+#import "ui/base/cocoa/base_view.h"

[Ilya Sherman, 2014/05/09 21:51:28]

nit: This is probably not needed -- right?

[Patrick Dubroy, 2014/05/12 14:13:39]

Done.

+#include "chrome/browser/ui/autofill/password_generation_popup_controller.h"
+#import "chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.h"

[Ilya Sherman, 2014/05/09 21:51:28]

nit: Should this be base_view?

[Patrick Dubroy, 2014/05/12 14:13:39]

Yep, fixed.

+#import "chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h"

[Ilya Sherman, 2014/05/09 21:51:28]

Am I misreading this, or is this header attempting to import itself?

[Patrick Dubroy, 2014/05/12 14:13:39]

Yes, not sure what happened there! Fixed.

+
+namespace autofill {
+class AutofillPopupController;
+}  // namespace autofill
+
+// Draws the native password generation popup view on Mac.
+@interface PasswordGenerationPopupViewCocoa : AutofillPopupBaseViewCocoa {
+ @private
+  // The cross-platform controller for this view.
+  __weak autofill::PasswordGenerationPopupController* controller_;
+}

[Ilya Sherman, 2014/05/09 21:51:28]

nit: Please leave a blank line after this one.

[Patrick Dubroy, 2014/05/12 14:13:39]

Done.

+// Designated initializer.
+- (id)initWithController:
+    (autofill::PasswordGenerationPopupController*)controller
+                   frame:(NSRect)frame;
+
+- (void)controllerDestroyed;
+
+@end
+
+#endif  // CHROME_BROWSER_UI_COCOA_AUTOFILL_PASSWORD_GENERATION_POPUP_VIEW_COCOA_H_